Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance lookup logs to show branches extended info #23696

Merged
merged 11 commits into from
Aug 14, 2023

Conversation

PhilipAbed
Copy link
Collaborator

Changes

Filtering the branches information and printing it even if its in dryRun:'lookup'

Context

The user would like to see on the dashboard that he has information about which upgrades he wants to have in lookup mode.
the same way we show it in the onboarding PR.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@PhilipAbed PhilipAbed requested a review from viceice August 3, 2023 14:46
@rarkins
Copy link
Collaborator

rarkins commented Aug 3, 2023

Can you show a before and after example?

@viceice viceice changed the title feat:Enhance lookup logs to show branches extended info feat: Enhance lookup logs to show branches extended info Aug 3, 2023
@PhilipAbed
Copy link
Collaborator Author

@rarkins

in lookup, it was not printing
Branch summary and Branches info extended

now it does

they were skipped on lookup, i moved the print outside the if( not lookup)

DEBUG: Branch summary (repository=StinkyLord/tutorial)
       "cacheModified": undefined,
       "baseBranches": [{"branchName": "main", "sha": "76cb5ac637942c920011f676d04655868ea26ce4"}],
       "branches": [],
       "defaultBranch": "main",
       "inactiveBranches": []
DEBUG: branches info extended (repository=StinkyLord/tutorial)
       "branchesInformation":[
         {
           "branchName": "renovate/lodash-monorepo",
           "prTitle": "Update dependency lodash to v4.17.21",
           "result": "no-work",
           "upgrades": [
             {
               "datasource": "npm",
               "depName": "lodash",
               "fixedVersion": "4.17.20",
               "currentVersion": "4.17.20",
               "currentValue": "4.17.20",
               "newValue": "4.17.21",
               "newVersion": "4.17.21",
               "packageFile": "package.json",
               "updateType": "patch",
               "packageName": "lodash"
             }
           ]
         },
         {
           "branchName": "renovate/date-io-monorepo",
           "prTitle": "Update date-io monorepo to v2.17.0",
           "result": "no-work",
           "upgrades": [
             {
               "datasource": "npm",
               "depName": "@date-io/date-fns",
               "fixedVersion": "2.10.0",
               "currentVersion": "2.10.0",
               "currentValue": "2.10.0",
               "newValue": "2.17.0",
               "newVersion": "2.17.0",
               "packageFile": "package.json",
               "updateType": "minor",
               "packageName": "@date-io/date-fns"
             },
             {
               "datasource": "npm",
               "depName": "@date-io/moment",
               "fixedVersion": "2.10.0",
               "currentVersion": "2.10.0",
               "currentValue": "2.10.0",
               "newValue": "2.17.0",
               "newVersion": "2.17.0",
               "packageFile": "package.json",
               "updateType": "minor",
               "packageName": "@date-io/moment"
             }
           ]
         },
         {
           "branchName": "renovate/commander-11.x",
           "prTitle": "Update dependency commander to v11",
           "result": "no-work",
           "upgrades": [
             {
               "datasource": "npm",
               "depName": "commander",
               "fixedVersion": "2.20.3",
               "currentVersion": "2.20.3",
               "currentValue": "2.20.3",
               "newValue": "11.0.0",
               "newVersion": "11.0.0",
               "packageFile": "package.json",
               "updateType": "major",
               "packageName": "commander"
             }
           ]
         }
       ]

@PhilipAbed PhilipAbed requested a review from viceice August 8, 2023 10:59
@viceice viceice requested a review from rarkins August 8, 2023 12:51
@rarkins rarkins added this pull request to the merge queue Aug 14, 2023
Merged via the queue into renovatebot:main with commit fe039fe Aug 14, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

rarkins added a commit that referenced this pull request Aug 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants