-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance lookup logs to show branches extended info #23696
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you show a before and after example? |
viceice
reviewed
Aug 3, 2023
in lookup, it was not printing now it does they were skipped on lookup, i moved the print outside the if( not lookup)
|
viceice
approved these changes
Aug 8, 2023
rarkins
approved these changes
Aug 14, 2023
🎉 This PR is included in version 36.43.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
6 tasks
rarkins
added a commit
that referenced
this pull request
Aug 21, 2023
)" This reverts commit fe039fe.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Filtering the branches information and printing it even if its in
dryRun:'lookup'
Context
The user would like to see on the dashboard that he has information about which upgrades he wants to have in lookup mode.
the same way we show it in the onboarding PR.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: