Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lerna)!: remove explicit lerna support #23907

Merged
merged 4 commits into from
Aug 27, 2023
Merged

feat(lerna)!: remove explicit lerna support #23907

merged 4 commits into from
Aug 27, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Aug 17, 2023

Changes

Remove Lerna <7 support

Context

Closes #23779

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins marked this pull request as ready for review August 17, 2023 04:54
rarkins
rarkins commented Aug 17, 2023
View reviewed changes
Copy link
Collaborator Author

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for v37

@viceice viceice changed the title feat(23779)!: drop lerna support feat(manager)!: drop lerna support Aug 17, 2023
@viceice viceice added the breaking Breaking change, requires major version bump label Aug 17, 2023
@viceice viceice mentioned this pull request Aug 17, 2023
Closed
5 tasks
@rarkins rarkins changed the base branch from main to v37 August 25, 2023 12:27
@rarkins rarkins requested a review from viceice August 25, 2023 12:31
@rarkins rarkins changed the title feat(manager)!: drop lerna support feat(lerna)!: remove explicit lerna support Aug 27, 2023
@rarkins rarkins merged commit 2a2845e into v37 Aug 27, 2023
33 checks passed
@rarkins rarkins deleted the breaking/23779-drop-lerna branch August 27, 2023 06:45
rarkins added a commit that referenced this pull request Aug 27, 2023
@rarkins
feat(lerna)!: remove explicit lerna support (#23907)
1c89f34
rarkins added a commit that referenced this pull request Aug 27, 2023
@rarkins
feat(lerna)!: remove explicit lerna support (#23907)
9c5e4fb
rarkins added a commit that referenced this pull request Aug 28, 2023
@rarkins
feat(lerna)!: remove explicit lerna support (#23907)
8737784
rarkins added a commit that referenced this pull request Sep 1, 2023
@rarkins
feat(lerna)!: remove explicit lerna support (#23907)
45f0218
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Lerna support
2 participants
@rarkins @viceice