feat: run GHA build job locally with act #23959
Conversation
lmilbaum
force-pushed
the
build
branch
2 times, most recently
from
dd0602b
to
98487fc
Compare
lmilbaum
changed the title
|
I usually use Makefiles although left it out of this project due to the number of Windows users. We face this challenge:
So @lmilbaum is there any strong benefit from this? |
lmilbaum
force-pushed
the
build
branch
2 times, most recently
from
6bee32f
to
c135ef8
Compare
|
@rarkins Thank you for your feedback. I'm testing something with the PR. It is in draft. Can we review its value or/and alternative options in a later stage? |
lmilbaum
force-pushed
the
build
branch
7 times, most recently
from
0937501
to
d583fb7
Compare
lmilbaum
changed the title
lmilbaum
force-pushed
the
build
branch
3 times, most recently
from
a2ffb29
to
532dc83
Compare
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v2.4.0 | ||
| with: |
There was a problem hiding this comment.
Setup node uses pnpm but the corepack is not enabled yet so the binary is missing.
There was a problem hiding this comment.
It is installed with the node setup
There was a problem hiding this comment.
sure, but corepack is also available if nodejs is already available
There was a problem hiding this comment.
Do we want to merge this before then? That PR is conflicted and waiting for someone to resume it and then hopefully the maintainers to merge it
There was a problem hiding this comment.
I do think it has value in merging it. Waiting for a general approval and then I'll rebase.
There was a problem hiding this comment.
We'll need a regex manager added to keep it updated though. It's already out of date :)
There was a problem hiding this comment.
I would prefer to leave the corepack enable when not on act. maybe we should build our own act image to not need the huge default act image.
lmilbaum
force-pushed
the
build
branch
2 times, most recently
from
4dead74
to
2324171
Compare
|
@viceice ping |
| @@ -462,6 +462,7 @@ jobs: | |||
|
|
|||
| - name: Upload | |||
| uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2 | |||
| if: ${{ !env.ACT }} | |||
There was a problem hiding this comment.
This step should not be enabled when running the pipeline with act
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v2.4.0 | ||
| with: |
There was a problem hiding this comment.
I would prefer to leave the corepack enable when not on act. maybe we should build our own act image to not need the huge default act image.
|
|
||
| - name: Setup Node | ||
| uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 | ||
| with: | ||
| node-version: ${{ inputs.node-version }} | ||
| cache: ${{ env.CACHE_HIT != 'true' && 'pnpm' || '' }} | ||
|
|
||
| - name: Enable corepack | ||
| shell: bash | ||
| run: corepack enable |
There was a problem hiding this comment.
this will probably not work when there is a pnpm in place
| ## Run GitHub Action build job locally with act | ||
|
|
||
| 1. Install act - [installation instructions](https://github.com/nektos/act#installation) | ||
| 1. Run (Pick the Large image) |
There was a problem hiding this comment.
why do we need the large image?
There was a problem hiding this comment.
I don't remember now why the large image is required. I do remember that the smaller image doesn't work.
|
Can this be moved forward to merging or should it be closed? |
Thanks @rarkins for reminding me of this PR. Closing. |
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: