Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Support releaseTimestamp for DockerHub tag results #24164

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

zharinov
Copy link
Collaborator

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Aug 31, 2023

I saw:

DEBUG: Docker: Failed to parse some tags from Docker Hub (repository=renovate-reproductions/dockertags1)
       "error": {
         "message": "Schema error",
         "stack": "ZodError: Schema error\n    at Object.transform (/Users/rhys/src/github/renovatebot/renovate/lib/util/schema-utils.ts:65:21)\n    at /Users/rhys/src/github/renovatebot/renovate/node_modules/.pnpm/zod@3.22.2/node_modules/zod/lib/types.js:2870:51\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)",
         "issues": {
           "492": {"tag_last_pushed": "Expected string, received null"},
           "493": {"tag_last_pushed": "Expected string, received null"},
           "494": {"tag_last_pushed": "Expected string, received null"},
           "___": "... 6 more"
         }
       }

I think it's best to silently ignore this missing field

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the digest?

lib/modules/datasource/docker/schema.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@zharinov zharinov requested a review from viceice August 31, 2023 06:48
@rarkins
Copy link
Collaborator

rarkins commented Aug 31, 2023

Digest is more complicated, I'm ok to do that separately

@rarkins rarkins added this pull request to the merge queue Aug 31, 2023
Merged via the queue into renovatebot:main with commit 2f4c711 Aug 31, 2023
36 checks passed
@rarkins rarkins deleted the feat/docker-hub-release-timestamp branch August 31, 2023 08:03
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.75.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include digest and releaseTimestamp from Docker Hub result
4 participants