Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelogs): protect against null host #24281

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 6, 2023

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should refactor this in the future to be more verbose what is actually failing 🤔

@rarkins rarkins added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit b6bc47f Sep 6, 2023
35 checks passed
@rarkins rarkins deleted the fix/changelog-host branch September 6, 2023 19:23
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.87.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -42,7 +42,7 @@ export class GitHubChangeLogSource extends ChangeLogSource {
} {
const sourceUrl = config.sourceUrl!;
const parsedUrl = URL.parse(sourceUrl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use our url utils 😁

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants