Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(presets): map PHP linters in default linters group #25072

Merged
merged 4 commits into from
Oct 8, 2023
Merged

feat(presets): map PHP linters in default linters group #25072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9624637
Add PHP linters to preset
Jean85 Oct 6, 2023
e00e27a
Update lib/config/presets/internal/packages.ts
viceice Oct 7, 2023
2d868bd
Run lint-fix
Jean85 Oct 7, 2023
d0b95dd
Fix snapshot tests
Jean85 Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/config/presets/__snapshots__/index.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ exports[`config/presets/index getPreset gets linters 1`] = `
"extends": [
"packages:emberTemplateLint",
"packages:eslint",
"packages:phpLinters",
"packages:stylelint",
"packages:tslint",
],
Expand Down Expand Up @@ -134,6 +135,9 @@ exports[`config/presets/index resolvePreset resolves linters 1`] = `
"matchPackageNames": [
"@types/eslint",
"babel-eslint",
"friendsofphp/php-cs-fixer",
"squizlabs/php_codesniffer",
"symplify/easy-coding-standard",
"codelyzer",
"prettier",
"remark-lint",
Expand Down Expand Up @@ -165,6 +169,9 @@ exports[`config/presets/index resolvePreset resolves nested groups 1`] = `
"matchPackageNames": [
"@types/eslint",
"babel-eslint",
"friendsofphp/php-cs-fixer",
"squizlabs/php_codesniffer",
"symplify/easy-coding-standard",
"codelyzer",
"prettier",
"remark-lint",
Expand Down
6 changes: 3 additions & 3 deletions lib/config/presets/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ describe('config/presets/index', () => {
config.extends = ['packages:linters'];
const res = await presets.resolveConfigPresets(config);
expect(res).toMatchSnapshot();
expect(res.matchPackageNames).toHaveLength(6);
expect(res.matchPackageNames).toHaveLength(9);
expect(res.matchPackagePatterns).toHaveLength(1);
expect(res.matchPackagePrefixes).toHaveLength(4);
});
Expand All @@ -256,7 +256,7 @@ describe('config/presets/index', () => {
expect(res).toMatchSnapshot();
const rule = res.packageRules![0];
expect(rule.automerge).toBeTrue();
expect(rule.matchPackageNames).toHaveLength(6);
expect(rule.matchPackageNames).toHaveLength(9);
expect(rule.matchPackagePatterns).toHaveLength(1);
expect(rule.matchPackagePrefixes).toHaveLength(4);
});
Expand Down Expand Up @@ -894,7 +894,7 @@ describe('config/presets/index', () => {
const res = await presets.getPreset('packages:linters', {});
expect(res).toMatchSnapshot();
expect(res.matchPackageNames).toHaveLength(3);
expect(res.extends).toHaveLength(4);
expect(res.extends).toHaveLength(5);
});

it('gets parameterised configs', async () => {
Expand Down
9 changes: 9 additions & 0 deletions lib/config/presets/internal/packages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export const presets: Record<string, Preset> = {
extends: [
'packages:emberTemplateLint',
'packages:eslint',
'packages:phpLinters',
'packages:stylelint',
'packages:tslint',
],
Expand All @@ -94,6 +95,14 @@ export const presets: Record<string, Preset> = {
description: 'All Mapbox-related packages.',
matchPackagePrefixes: ['leaflet', 'mapbox'],
},
phpLinters: {
description: 'All PHP lint-related packages.',
matchPackageNames: [
'friendsofphp/php-cs-fixer',
'squizlabs/php_codesniffer',
'symplify/easy-coding-standard',
],
},
postcss: {
description: 'All PostCSS packages.',
matchPackageNames: ['postcss'],
Expand Down