feat(presets): update java LTS workaround to include liberica #25285
Conversation
Signed-off-by: Craig Andrews <candrews@integralblue.com>
|
🎉 This PR is included in version 37.31.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
| @@ -118,7 +118,10 @@ export const presets: Record<string, Preset> = { | |||
| 'java-jre', | |||
| 'sapmachine', | |||
| ], | |||
| matchPackagePatterns: ['^azul/zulu-openjdk'], | |||
| matchPackagePatterns: [ | |||
| '^azul/zulu-openjdk', | |||
There was a problem hiding this comment.
I know this is already merged, but shouldn't the azul and bellsoft packages be added to the matchPackageNames array above so that it follows the javaLTSVersions allowedVersions expression?
There was a problem hiding this comment.
The azul and bellsoft names are not exact matches, and I believe matchPackageNames needs exact matches:
Use this field if you want to have one or more exact name matches in your package rule.
https://docs.renovatebot.com/configuration-options/#matchpackagenames
There was a problem hiding this comment.
The intent of this this javaLTSVersions preset when I originally created it was to keep updates only to LTS versions (ie: 8, 11, 17, 21) etc...
If we aren't adding the azul and bellsoft flavors to the allowedVersions range, then perhaps this is better suited to a new java-based preset
There was a problem hiding this comment.
The intent of this this javaLTSVersions preset when I originally created it was to keep updates only to LTS versions (ie: 8, 11, 17, 21) etc...
Yes, that's what I intend with the azul and liberica images. Currently, Renovate tries to bump those image references to non-LTS versions (ex, 18) - the intent is to only bump to LTS versions.
There was a problem hiding this comment.
Ah, in that case I think you'll need to duplicate the allowedVersions into your package rule
There was a problem hiding this comment.
It's the same package rule - can you please clarify what should be duplicate and where?
There was a problem hiding this comment.
Apologies @candrews - the diff was rendering strangely on my mobile. Please ignore my comments and thanks for enhancing this workaround
…tebot#25285) Signed-off-by: Craig Andrews <candrews@integralblue.com>
Changes
Match the bellsoft liberica openjdk/openjre images in the
javaLTSVersionspreset.Bellsoft's documentation for their images: https://bell-sw.com/blog/bellsoft-s-docker-hub-images-overview/
An example image is: https://hub.docker.com/r/bellsoft/liberica-openjdk-debian
Liberica is the Java distribution used by default by Paketo buildpacks: https://paketo.io/docs/howto/java/#use-an-alternative-jvm
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: