Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): mergeable repositoryAliases global option #26848

Merged
merged 5 commits into from Jan 29, 2024

Conversation

eschleining
Copy link
Contributor

Changes

This should fix the repositoryAliases that are being defined in renovate.js or via the env var RENOVATE_REPOSITORY_ALIASES not actually being picked up as mentioned int he discussion.

Context

#26756

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

…default/manager option

This should fix the repositoryAliases that are being defined in renovate.js or via the env var RENOVATE_REPOSITORY_ALIASES not actually being picked up as mentioned int he discussion
renovatebot#26756
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 @rarkins @secustor this would be a breaking change. do we want this change?

@viceice viceice changed the title fix(managers/helmv3): mergeable repositoryAliases global option feat(config): mergeable repositoryAliases global option Jan 24, 2024
secustor
secustor previously approved these changes Jan 24, 2024
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense IMO.
I can not come up with a scenario in which we would break existing setups in which people use registryAliases.

rarkins
rarkins previously approved these changes Jan 25, 2024
@viceice
Copy link
Member

viceice commented Jan 26, 2024

@eschleining please don't merge main if not needed, you'll block automerge 🙃

viceice
viceice previously approved these changes Jan 26, 2024
@eschleining
Copy link
Contributor Author

eschleining commented Jan 26, 2024 via email

@viceice
Copy link
Member

viceice commented Jan 26, 2024

Oh ok, thanks for letting me know. There are failing tests. Should I fix
them?

Michael Kriese @.***> schrieb am Fr., 26. Jan. 2024,
21:13:

@eschleining https://github.com/eschleining please don't merge main if
not needed, you'll block automerge 🙃


Reply to this email directly, view it on GitHub
#26848 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGKE4OTOATCZC5LGCWL2M3YQQFAPAVCNFSM6AAAAABCJJ4YMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGYZTGMRVHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

yes

auto-merge was automatically disabled January 26, 2024 20:55

Head branch was pushed to by a user without write access

@eschleining eschleining dismissed stale reviews from viceice, secustor, and rarkins via 689cb09 January 26, 2024 20:55
@viceice viceice changed the title feat(config): mergeable repositoryAliases global option feat(config): mergeable repositoryAliases global option Jan 29, 2024
@viceice viceice added this pull request to the merge queue Jan 29, 2024
Merged via the queue into renovatebot:main with commit c9a8a72 Jan 29, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.158.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

rvanbutselaar pushed a commit to rvanbutselaar/renovate that referenced this pull request Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants