Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource): Check release constraints validity #27191

Merged
38 changes: 30 additions & 8 deletions lib/modules/datasource/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -181,14 +181,36 @@ export function applyConstraintsFiltering<
continue;
}

const satisfiesConstraints = constraint.some(
// If the constraint value is a subset of any release's constraints, then it's OK
// fallback to release's constraint match if subset is not supported by versioning
(releaseConstraint) =>
!releaseConstraint ||
(versioning.subset?.(configConstraint, releaseConstraint) ??
versioning.matches(configConstraint, releaseConstraint)),
);
let satisfiesConstraints = false;
for (const releaseConstraint of constraint) {
if (!releaseConstraint) {
viceice marked this conversation as resolved.
Show resolved Hide resolved
satisfiesConstraints = true;
break;
}

// istanbul ignore if: defensive programming
if (!versioning.isValid(releaseConstraint)) {
logger.once.debug(
{
packageName: config.packageName,
versioning: versioningName,
constraint: releaseConstraint,
},
'Invalid release constraint',
);
continue;
}
zharinov marked this conversation as resolved.
Show resolved Hide resolved

if (versioning.subset?.(configConstraint, releaseConstraint)) {
satisfiesConstraints = true;
break;
}

if (versioning.matches(configConstraint, releaseConstraint)) {
satisfiesConstraints = true;
break;
}
}

if (!satisfiesConstraints) {
filteredReleases.push(release.version);
Expand Down