Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix codecov uploads #27278

Merged
merged 14 commits into from
Feb 14, 2024
Merged

ci: Fix codecov uploads #27278

merged 14 commits into from
Feb 14, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Feb 13, 2024

Changes

  • Split the coverage task to the codecov and coverage-threshold parts
  • Revert codecov-action to v3, which allows to upload reports created from fork PRs

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

It looks like we're reverting to v3, until the issues are fixed on the Codecov side

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be conflicted after #27268 merge

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
zharinov and others added 3 commits February 14, 2024 09:14
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
# Conflicts:
#	.github/workflows/build.yml
viceice
viceice previously approved these changes Feb 14, 2024
auto-merge was automatically disabled February 14, 2024 14:04

Head branch was pushed to by a user without write access

@viceice viceice added this pull request to the merge queue Feb 14, 2024
Merged via the queue into renovatebot:main with commit 7454428 Feb 14, 2024
35 checks passed
@viceice viceice deleted the fix/ci-codecov-v4 branch February 14, 2024 14:15
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.190.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants