Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/custom): allow packageName instead of depName #28834

Merged
merged 13 commits into from
May 5, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented May 4, 2024

Changes

Refactors regex customer manager so that packageName can be extracted instead of depName, meaning depName is no longer mandatory.

Context

Transition to packageName-first extraction.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins enabled auto-merge May 5, 2024 05:59
@rarkins rarkins requested review from viceice and secustor May 5, 2024 06:00
lib/modules/manager/custom/regex/readme.md Outdated Show resolved Hide resolved
lib/modules/platform/gerrit/scm.ts Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/modules/manager/custom/regex/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/custom/regex/readme.md Show resolved Hide resolved
rarkins and others added 2 commits May 5, 2024 13:30
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@rarkins rarkins added this pull request to the merge queue May 5, 2024
Merged via the queue into main with commit cf724cf May 5, 2024
37 checks passed
@rarkins rarkins deleted the feat/regex-manager-package-name branch May 5, 2024 12:21
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.342.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@latin-1
Copy link
Contributor

latin-1 commented May 13, 2024

https://github.com/renovatebot/renovate/blob/main/lib/config/presets/internal/custom-managers.ts

Should we replace all depNameTemplate with packageNameTemplate in this file?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants