-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config/validation): add validation for negative numbers #29178
feat(config/validation): add validation for negative numbers #29178
Conversation
Are you sure we never use a negative number like -1 intentionally? |
We do but only for |
I think that this PR is maybe oversimplifying things. Not all numbers need to be positive, even if most are. A broad rule doesn't work. Also yes, prPriority should always be part of packageRules |
We can add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test against a real repo and show us the results.
🎉 This PR is included in version 37.387.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Context
Ref this discussion: #29137 (comment)
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: