Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pdm): change pdm update strategy to eager #29183

Merged
merged 2 commits into from
May 21, 2024
Merged

fix(pdm): change pdm update strategy to eager #29183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a05cdf3
fix: change pdm update strategy to eager
huxuan May 21, 2024
55fb916
update test
huxuan May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/modules/manager/pep621/artifacts.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ requires-python = "<3.9"
'&& ' +
'install-tool pdm v2.5.0 ' +
'&& ' +
'pdm update --no-sync dep1' +
'pdm update --no-sync --update-eager dep1' +
'"',
options: {
cwd: '/tmp/github/some/repo',
Expand Down
12 changes: 6 additions & 6 deletions lib/modules/manager/pep621/processors/pdm.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ describe('modules/manager/pep621/processors/pdm', () => {
'&& ' +
'install-tool pdm v2.5.0 ' +
'&& ' +
'pdm update --no-sync dep1' +
'pdm update --no-sync --update-eager dep1' +
'"',
},
]);
Expand Down Expand Up @@ -177,16 +177,16 @@ describe('modules/manager/pep621/processors/pdm', () => {
]);
expect(execSnapshots).toMatchObject([
{
cmd: 'pdm update --no-sync dep1 dep2',
cmd: 'pdm update --no-sync --update-eager dep1 dep2',
},
{
cmd: 'pdm update --no-sync -G group1 dep3 dep4',
cmd: 'pdm update --no-sync --update-eager -G group1 dep3 dep4',
},
{
cmd: 'pdm update --no-sync -dG group2 dep5 dep6',
cmd: 'pdm update --no-sync --update-eager -dG group2 dep5 dep6',
},
{
cmd: 'pdm update --no-sync -dG group3 dep7 dep8',
cmd: 'pdm update --no-sync --update-eager -dG group3 dep7 dep8',
},
]);
});
Expand Down Expand Up @@ -228,7 +228,7 @@ describe('modules/manager/pep621/processors/pdm', () => {
]);
expect(execSnapshots).toMatchObject([
{
cmd: 'pdm update --no-sync',
cmd: 'pdm update --no-sync --update-eager',
options: {
cwd: '/tmp/github/some/repo/folder',
},
Expand Down
2 changes: 1 addition & 1 deletion lib/modules/manager/pep621/processors/pdm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { PdmLockfileSchema, type PyProject } from '../schema';
import { depTypes, parseDependencyGroupRecord } from '../utils';
import type { PyProjectProcessor } from './types';

const pdmUpdateCMD = 'pdm update --no-sync';
const pdmUpdateCMD = 'pdm update --no-sync --update-eager';
rarkins marked this conversation as resolved.
Show resolved Hide resolved

export class PdmProcessor implements PyProjectProcessor {
process(project: PyProject, deps: PackageDependency[]): PackageDependency[] {
Expand Down