feat(leiningen): support lein-parent #29552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for 'parent-project' functionality, which is used by the [lein-parent][1] project. `:parent-project` is expected to specify a single dependency, under the `:coords` key. Two notable changes have been made to facilitate this: 1. `extractFromVectors` allows the vector dimension to be specified. This was previously assumed to be 2, but 1 has now been added to support single "bare" dependencies. I'm not aware of anything in the Lein ecosystem that would mandate values other than 1 or 2. 2. `collectDeps` accepts an options object for specifying whether the deps are nested (dimensions = 2) or not (dimensions = 1). It also allows specifying the `depType` explicitly, so we can have the relevant dependency at the path `[:parent-project :coords]` be labelled `parent-project`, rather than the less descriptive `coords` [1]: https://github.com/achin/lein-parent Relates to renovatebot#7815
|
|
MIJOTHY
commented
Jun 9, 2024
lib/modules/manager/leiningen/__snapshots__/extract.spec.ts.snap
Outdated
Show resolved
Hide resolved
lib/modules/manager/leiningen/__snapshots__/extract.spec.ts.snap
Outdated
Show resolved
Hide resolved
viceice
reviewed
Jun 15, 2024
viceice
added
the
auto:no-done-comments
|
Hi there, You are using Good luck, The Renovate team |
viceice
approved these changes
Jun 15, 2024
secustor
approved these changes
Jun 16, 2024
|
🎉 This PR is included in version 37.409.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit adds support for 'parent-project' functionality, which is used by the lein-parent project.
:parent-projectis expected to specify a single dependency, under the:coordskey. Two notable changes have been made to facilitate this:extractFromVectorsallows the vector dimension to be specified. This was previously assumed to be 2, but 1 has now been added to support single "bare" dependencies. I'm not aware of anything in the Lein ecosystem that would mandate values other than 1 or 2.collectDepsaccepts an options object for specifying whether the deps are nested (dimensions = 2) or not (dimensions = 1). It also allows specifying thedepTypeexplicitly, so we can have the relevant dependency at the path[:parent-project :coords]be labelledparent-project, rather than the less descriptivecoordsContext
I have the same use-case as #7815
Documentation (please check one with an [x])
I can explicitly call out
lein-parentsupport in the docs if desired.How I've tested my work (please select one)
I have verified these changes via: