refactor: revert replace emoji shortcodes with their unicode equivalent #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is related to #3799 |
nvdbleek
changed the title
|
Sorry, I didn’t see this one when I merged my own revert earlier. Just seeing it now. |
1 similar comment
|
Sorry, I didn’t see this one when I merged my own revert earlier. Just seeing it now. |
|
@rarkins no problem. Thank you for picking it up so fast. I will work on the real 'fix' and make it configurable tonight. But I don't think I'll be able to finish this tonight. Is it OK if I get this done before Monday morning? |
|
Already reverted in 3465ea7 |
|
@nvdbleek no problem at all. Feel free to float your proposed solution for feedback first. I was thinking maybe a new function like lib/util/emoji.js that returns the right text based on the configured preference. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent (#4000)"
This reverts commit 6956665.
This PR reverts the emoji shortcodes to Unicode character change. We will make it configurable to use either shortcodes or Unicode characters because old versions bitbucket server/MySQL have problems with the 4-byte Unicode characters.