Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: helmfile manager #5257

Merged
merged 11 commits into from
Feb 2, 2020
Merged

feat: helmfile manager #5257

merged 11 commits into from
Feb 2, 2020

Conversation

gmelillo
Copy link
Contributor

Basic coverage of helmfile.yaml.
At the moment does not support go-template variable for cases like this:

releases:
  - name: nginx-ingress
    namespace: ingress
    version: 0.3.2
    chart: stable/{{`{{ .Release.Name }}`}}

Closes #4967

@claassistantio
Copy link

claassistantio commented Jan 29, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gmelillo gmelillo requested a review from rarkins January 29, 2020 21:56
@gmelillo
Copy link
Contributor Author

@rarkins still missing tests but should cover the basic use cases. I'll like to have some feedback on the implementation

rarkins
rarkins requested changes Jan 30, 2020
View reviewed changes
lib/manager/helmfile/extract.ts Outdated Show resolved Hide resolved
lib/manager/helmfile/extract.ts Outdated Show resolved Hide resolved
lib/manager/helmfile/extract.ts Outdated Show resolved Hide resolved
lib/manager/helmfile/extract.ts Outdated Show resolved Hide resolved
lib/manager/helmfile/extract.ts Outdated Show resolved Hide resolved
gmelillo and others added 11 commits February 1, 2020 13:32
@gmelillo
feat(helmfile): first implementation of helmfile manager
1f6eb41
@gmelillo
chore(test): snapshot update to validate the new manager
4ca1515 
Signed-off-by: Gabriel Melillo <gabriel@melillo.me>
@gmelillo
chore(test): addeed some test for helmfile/extract
61f55fe 
Signed-off-by: Gabriel Melillo <gabriel@melillo.me>
@gmelillo
fix(helmfile): to support multiple version of the same chart
c1358d7
@gmelillo
chore(test): addeed some test for helmfile/update
fcb8bd8 
Signed-off-by: Gabriel Melillo <gabriel@melillo.me>
@gmelillo
fix(helmfile): changed logging strategy
c1edc2b 
Signed-off-by: Gabriel Melillo <gabriel@melillo.me>
@gmelillo
chore(test): added test for the last cases
2a64cff 
Signed-off-by: Gabriel Melillo <gabriel@melillo.me>
@gmelillo @rarkins
chore(log): better logging on lib/manager/helmfile/extract.ts
243baaf 
Co-Authored-By: Rhys Arkins <rhys@arkins.net>
@gmelillo @rarkins
refactor(helm): make filter more clean
4264a36 
Co-Authored-By: Rhys Arkins <rhys@arkins.net>
@gmelillo
fix(skipreason): make better comunication of the issue
0a49e6f
@gmelillo
fix(re): removed unused dependency
3d4a470 
Signed-off-by: Gabriel Melillo <gabriel@melillo.me>
@gmelillo gmelillo requested a review from rarkins February 1, 2020 12:39
@gmelillo gmelillo changed the title feat(helmfile): first implementation of helmfile manager [WIP] feat(helmfile): first implementation of helmfile manager Feb 1, 2020
@rarkins rarkins changed the title feat(helmfile): first implementation of helmfile manager feat: helmfile manager Feb 2, 2020
@rarkins rarkins merged commit 30f0c42 into renovatebot:master Feb 2, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.117.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
@gmelillo gmelillo deleted the feat/helmfile-4967 branch April 28, 2023 05:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for helmfile.yaml
4 participants
@gmelillo @claassistantio @renovate-release @rarkins