Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove authorization header from core.windows.net requests for Azure docker registries #5274

Merged
merged 6 commits into from Feb 4, 2020
Merged

fix: Remove authorization header from core.windows.net requests for Azure docker registries #5274

merged 6 commits into from Feb 4, 2020

Conversation

joeapearson
Copy link
Contributor

Closes #5273

@joeapearson
Copy link
Contributor Author

I think this could really do with some tests - I had a quick look to see how it could be done but I couldn't figure out how to get into that beforeRedirect hook without spending more time

@rarkins
Copy link
Collaborator

rarkins commented Feb 1, 2020

I think this could really do with some tests

do it live

viceice
viceice requested changes Feb 3, 2020
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs unit tests to fix coverage

@joeapearson
Copy link
Contributor Author

Added some tests. If you prefer not to add an extra export to docker.ts then please can you suggest something? Otherwise I suggest adding an extra file alongside it that exports just this hook function.

viceice
viceice requested changes Feb 4, 2020
View reviewed changes
lib/datasource/docker/index.ts Outdated Show resolved Hide resolved
lib/datasource/docker/index.ts Outdated Show resolved Hide resolved
lib/datasource/docker/index.ts Show resolved Hide resolved
viceice
viceice approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/datasource/docker/index.ts Show resolved Hide resolved
@rarkins rarkins merged commit 4c258e2 into renovatebot:master Feb 4, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.120.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

rarkins added a commit that referenced this pull request Feb 28, 2020
@rarkins
fix: Revert "fix: Remove authorization header from core.windows.net r…
74f24d5 
…equests… (#5274)"

This reverts commit 4c258e2.

# Conflicts:
#	lib/datasource/docker/index.ts
This was referenced Jun 30, 2020
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins left review comments

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to authorize azurecr.io docker registries
4 participants
@joeapearson @rarkins @renovate-release @viceice