Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gradle): Also update buildscript dependencies from settings.gradle #5380

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

jGleitz
Copy link
Contributor

@jGleitz jGleitz commented Feb 5, 2020

I have tested it on my reproduction repository: https://github.com/jGleitz/renovate-test-settings-gradle/pull/2 (The PR was not created by the current version of renovate, but only after I executed renovate with this fix locally).

Closes #5379

@jGleitz
Copy link
Contributor Author

jGleitz commented Feb 5, 2020

I could not find any tests for the changed file. If somebody points be towards how to test it, I will add an automated test.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be safe to merge too

@rarkins rarkins merged commit d1eb303 into renovatebot:master Feb 5, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.120.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jGleitz jGleitz deleted the 5379-update-settings-gradle branch February 6, 2020 10:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

renovate fails to detect update in settings.gradle
4 participants