Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): semantic-release on actions #5515

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 19, 2020

Closes #5514

@rarkins rarkins marked this pull request as ready for review February 19, 2020 09:02
@rarkins rarkins changed the title chore: semantic-release on actions fix(meta): semantic-release on actions Feb 19, 2020
@rarkins rarkins merged commit 54eb358 into master Feb 19, 2020
@rarkins rarkins deleted the chore/actions-release branch February 19, 2020 09:50
@github-actions
Copy link
Contributor

🎉 This PR is included in version 19.140.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice
Copy link
Member

viceice commented Feb 19, 2020

should we use the renovate-release token for release? so now we have the github-actions bot as releaser

@rarkins
Copy link
Collaborator Author

rarkins commented Feb 19, 2020

I don't see much downside in having the github-actions bot do it though, do you see any? One less token to manage

@viceice
Copy link
Member

viceice commented Feb 19, 2020

No, it's fine. just to mention. :-)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta: move semantic-release from circle to actions
2 participants