refactor: move user-agent insertion from got to http

[rarkins]

Move user-agent string insertion from util/got extension into util/http wrapper

[rarkins]

@szmarczak could you take a look at this one?

We are mostly done with Renovate refactoring in order to be able to move more easily to got 11, but this is one of the last steps.

I thought this would make no changes but it has.

I replaced the existing got.extend() approach with simply adding the header before calling got() and now our nock-based tests report that the accept header has been dropped, e.g.

Here's what was removed:

Here's what was added:

I notice that the deleted renovate.agent.ts was the only file where we used got.extend whereas the remaining three we have use export default create. What do you suggest?

[rarkins]

I removed all the updated .snap files from this PR for now to make it easier to review. You can see the failures in the GitHub Actions CI reports though.

[rarkins]

If I leave the renovate-agent.ts as an empty extension then things work as expected:

export default got.extend({
  headers: {},
});

[rarkins]

Without this, a hundred snapshots fail due to changed headers

[szmarczak]

Please try passing decompress: true in the options and see if that fixes things.

[szmarczak]

This is the condition for the accept-encoding header to be present:

https://github.com/sindresorhus/got/blob/a45e071e8dc5027ab9c7fad5919195501cd9e9ca/source/normalize-arguments.js#L187-L189

[rarkins]

This is the condition for the accept-encoding header to be present:

sindresorhus/got:source/normalize-arguments.js@a45e071#L187-L189

So for some reason that is triggered if we have an empty got.extend({}) but it's not triggered otherwise. Is that expected?

I have simplified this PR a little further btw, it should be clearer to see.

[szmarczak]

It's because all the other instances you provide have empty options:

renovate/lib/util/got/cache-get.ts

Line 17 in 2ce73f8

options: {},

renovate/lib/util/got/host-rules.ts

Line 9 in 2ce73f8

options: {},

renovate/lib/util/got/auth.ts

Line 10 in 2ce73f8

options: {},

So you need to pass

export const api = mergeInstances(got, cacheGet, hostRules, auth);

[rarkins]

And to clarify: got does not offer to accept encoding for gzip unless explicitly enabled by the client calling it?

[szmarczak]

And to clarify: got does not offer to accept encoding for gzip unless explicitly enabled by the client calling it?

It's on by default but you forgot to extend got just once :P In Got 11 there's no got.create, you need to use got.extend instead. https://github.com/sindresorhus/got/#gotextendoptions

[renovate-release]

🎉 This PR is included in version 21.6.6 🎉

The release is available on:

• GitHub release
• 21.6.6

Your semantic-release bot 📦🚀