chore(maven): Add 'editFile' field to extracted deps #6752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
reviewed
Jul 14, 2020
lib/manager/maven/extract.ts
Outdated
| @@ -137,6 +137,10 @@ function applyProps( | |||
| result.skipReason = SkipReason.VersionPlaceholder; | |||
| } | |||
|
|
|||
| if (propSource) { | |||
There was a problem hiding this comment.
Will propSource ever be a duplicate of packageFile?
There was a problem hiding this comment.
Yes, it can be assigned only from it. Though I can't figure out it's meaning and when it will be different from new editFile
There was a problem hiding this comment.
Let's only include it if it's different to packageFile
zharinov
commented
Jul 14, 2020
| "currentValue": "1.2.3.4", | ||
| "datasource": "maven", | ||
| "depName": "org.example:quux", | ||
| "editFile": "parent.pom.xml", |
rarkins
changed the title
rarkins
approved these changes
Jul 14, 2020
viceice
approved these changes
Jul 14, 2020
|
🎉 This PR is included in version 21.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.