Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(platform): move optimizeForDisabled, isFork logic to worker layer #7379

Merged
merged 14 commits into from
Oct 2, 2020
Merged

refactor(platform): move optimizeForDisabled, isFork logic to worker layer #7379

merged 14 commits into from
Oct 2, 2020

Conversation

zharinov
Copy link
Collaborator

Closes #7364

@zharinov zharinov marked this pull request as draft September 29, 2020 19:38
@zharinov
Copy link
Collaborator Author

Needs to be tested with real repos

@rarkins rarkins changed the title Refactor/init repo common errors refactor(platform): move optimizeForDisabled logic to worker layer Sep 30, 2020
@rarkins rarkins changed the title refactor(platform): move optimizeForDisabled logic to worker layer refactor(platform): move optimizeForDisabled, isFork logic to worker layer Sep 30, 2020
@zharinov
Copy link
Collaborator Author

Can confirm it worked without failures for me

@zharinov zharinov marked this pull request as ready for review September 30, 2020 14:03
viceice
viceice requested changes Sep 30, 2020
View reviewed changes
lib/workers/repository/init/apis.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/apis.ts Outdated Show resolved Hide resolved
viceice
viceice requested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need to extend the git-sumodule test timeout, cause it begans to be flaky too.

lib/workers/repository/init/apis.spec.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Oct 1, 2020

Anyone got any idea why we'd be exceeding 5s for submodule tests?

@viceice
Copy link
Member

viceice commented Oct 1, 2020

image
😢

viceice
viceice requested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now need tests for getJsonFile for each platform.

@zharinov zharinov mentioned this pull request Oct 1, 2020
Merged
@zharinov
Copy link
Collaborator Author

zharinov commented Oct 1, 2020

Other platforms are okay

@viceice
Copy link
Member

viceice commented Oct 1, 2020

image

image

missing coverage on all platforms when testing locally

zharinov
zharinov commented Oct 1, 2020
View reviewed changes
lib/platform/common.ts Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Oct 2, 2020
View reviewed changes
viceice
viceice previously approved these changes Oct 2, 2020
View reviewed changes
@rarkins rarkins dismissed stale reviews from viceice and themself via 7f41d65 October 2, 2020 06:46
@rarkins rarkins merged commit 517f5ec into renovatebot:master Oct 2, 2020
@rarkins rarkins deleted the refactor/init-repo-common-errors branch October 2, 2020 09:57
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins left review comments

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: move optimizeForDisabled logic into worker layer
4 participants
@zharinov @rarkins @viceice @renovate-release