Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuget): add support for centralized PackageVersion #7622

Merged

Conversation

dobrou
Copy link
Contributor

@dobrou dobrou commented Nov 1, 2020

Changes:

Add support for centralized nuget PackageVersion property name.
New dotnet feature, described e.g. here https://stu.dev/managing-package-versions-centrally/, allows easier nuget dependencies versions management.
However this feature uses new property name in config files.

So I added parsing of new property name into nuget manager.

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@ghost
Copy link

ghost commented Nov 1, 2020

Hey there! 👋 This repository uses the Prettier code style.

You forgot to format these files in your pull request:

  • lib/manager/nuget/extract.spec.ts
  • lib/manager/nuget/extract.ts

The Prettier installation guide
is a good place to get started with formatting your code properly. Thanks!!

❤️

Your friendly Prettifier bot

@dobrou dobrou changed the title Add support for centralized nuget PackageVersion feat(nuget): Add support for centralized nuget PackageVersion Nov 1, 2020
@viceice viceice changed the title feat(nuget): Add support for centralized nuget PackageVersion feat(nuget): add support for centralized PackageVersion Nov 1, 2020
@dobrou
Copy link
Contributor Author

dobrou commented Nov 1, 2020

I'm not sure about the Prettier comment above,
running yarn prettier --write . locally on this branch does not report any issue and does not change any file.

So I will ignore the bot comment here, unless anyone would have different opinion.

@rarkins rarkins merged commit cdaf3e9 into renovatebot:master Nov 1, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.67.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants