feat: Add branch option for postUpgradeCommands

[marcodejongh]

Changes:

Returns the old postUpgradeTask behaviour under a extra flag
Fixes #8220

Context:

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added unit tests, or
• No new tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[marcodejongh]

@sarunint Would you mind helping me on this PR?

[marcodejongh]

@viceice Yeah for sure it needs to be abstracted, only reason I didn't straight away is because I wanted to make sure this change worked. I've tested it locally and it works, so I'll work on abstracting it now to get this into a mergable state later this week

[kenotron]

@marcodejongh - very much appreciate this work. An example of usage for me is to execute a bit of logic with https://microsoft.github.io/beachball/ to generate a change file for later automated semver bumping of package versions.

[marcodejongh]

@rarkins @viceice I've updated the PR and pulled the post upgrade command executor to a separate file, considering how intertwined it's functionality is with the regular branch worker, I kept the tests in the branch worker itself.

[marcodejongh]

@sarunint Would you mind running this branch on your codebase which I assume depends on the behavior change you made?

We'll run the newly added branch mode on our test repository

[sarunint]

@sarunint Would you mind running this branch on your codebase which I assume depends on the behavior change you made?

We'll run the newly added branch mode on our test repository

Sure, I'll test it later today.

[marcodejongh]

Oops didn't intend to force push, but I didn't know how the eslint pre commit works in this repo.
All feedback has been addressed and the PR should be ready for another review

[viceice]

just small changes

[viceice]

Suggested change

getAdminConfig().trustLevel !== 'high' ||

I think if you already set allowedPostUpgradeCommands admin config we do not also require trustLevel

[marcodejongh]

Hmmm are you sure? I global searched the repo and I didn't see any checks for trustLevel and allowedPostUpgradeCommands.
For now I've cleaned up the statement, no need to call getAdminConfig twice

[viceice]

😏

[viceice]

😉

[viceice]

Please check and remove all casts which are not required by typescript (which you've changed).

[viceice]

@rarkins needs your approval

[viceice]

@marcodejongh We can't update your branch, please use the update button, otherwise i'm not able to merge.

[marcodejongh]

@viceice Hmmm I can't merge it myself either? Maybe something is setup wrong on our atlassian-forks org

[marcodejongh]

Or actually I think it would be a permission on this repo that is preventing merging. In the Github UI "base branch" is the target branch

[viceice]

The branch update feature does not work cross orgs, it only works for personal accounts.

An alternate is to give us write permission to your fork, so we can update your branch if required.

[renovate-release]

🎉 This PR is included in version 24.109.0 🎉

The release is available on:

• GitHub release
• 24.109.0

Your semantic-release bot 📦🚀