Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gomod): do not shorten depName #8758

Merged
merged 4 commits into from Feb 18, 2021
Merged

feat(gomod): do not shorten depName #8758

merged 4 commits into from Feb 18, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Feb 18, 2021

Changes:

Moved the depName shorten to the depNameShort compatibillity part.

Declaring it as feature to have more visibillity of the change.

Context:

fixes #8691

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins February 18, 2021 12:32
@viceice viceice changed the title fix(gomod): do not shorten feat(gomod): do not shorten Feb 18, 2021
@viceice viceice marked this pull request as ready for review February 18, 2021 12:47
@viceice
Copy link
Member Author

viceice commented Feb 18, 2021

@rarkins What do you think about the depNameShort helper?

@viceice viceice requested a review from rarkins February 18, 2021 14:49
@rarkins
Copy link
Collaborator

rarkins commented Feb 18, 2021

This is going to cause all Go branchNames to change. Did they change previously when we removed depNameShort or were we using depNameShort in the branch name before?

@viceice
Copy link
Member Author

viceice commented Feb 18, 2021

This is going to cause all Go branchNames to change. Did they change previously when we removed depNameShort or were we using depNameShort in the branch name before?

yes, they all changed before from long to short, so this is a kind of revert to have long names

@rarkins rarkins changed the title feat(gomod): do not shorten feat(gomod): do not shorten depName Feb 18, 2021
@rarkins rarkins merged commit 9a1c4fa into master Feb 18, 2021
@rarkins rarkins deleted the fix/go-shortening branch February 18, 2021 15:27
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.55.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not shortening go modules
3 participants