feat(terragrunt-version): implement tgenv version file updates #8816
Conversation
|
|
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…e.md Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
| const dep: PackageDependency = { | ||
| depName: 'gruntwork-io/terragrunt', | ||
| currentValue: content.trim(), | ||
| datasource: datasourceGitHubRelease.id, |
There was a problem hiding this comment.
I guess terragrunt uses terraform versioning?, so should be added here too.
There was a problem hiding this comment.
Not sure I understand.
terragrunt uses terraform versioning in what way?
There was a problem hiding this comment.
Looks like we need a custom versioning here
https://github.com/cunymatthieu/tgenv#terragrunt-version
can be a version, latest or latest:<regex> so we should at least ignore the latest values with this pr, otherwise renovate would try to update them to real versions.
like here:
renovate/lib/manager/gomod/extract.ts
Lines 24 to 26 in 9a1c4fa
There was a problem hiding this comment.
Firstly, thanks for all the feedback!
As you've likely figured out by now I'm not familiar with this codebase or typescript 😅
So this PR may be open for a while as a figure it out 🙃
Can I make the case for not including this right now?
- tfenv has the same versioning: https://github.com/tfutils/tfenv#terraform-version-file
- Yet that's not supported fully in the
terraform-versionmanager in renovate
- Yet that's not supported fully in the
- I'd argue the main use case of these version managers tools when combined with renovate are precise version bumps
There was a problem hiding this comment.
so terraform-version manager is wrong too 🙈
There was a problem hiding this comment.
The lookup process will already do a filter based on isValid(). We prefer not to set unsupported version in manager extracts so that users can configure a custom versioning using package rules that gets applied post-extract and pre-validation
How do I just run my test? I'm using the dev container |
|
yarn jest terragrunt -u |
|
🎉 This PR is included in version 24.64.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Closes: #8815
Context:
See example renovate PR: sajidk1/renovate-test#1
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: