fix: abort branch if child process receives SIGTERM

lib/constants/error-messages.ts

@@ -35,6 +35,7 @@ export const REPOSITORY_UNINITIATED = 'uninitiated';
 export const REPOSITORY_CHANGED = 'repository-changed';
 export const TEMPORARY_ERROR = 'temporary-error';
 export const NO_VULNERABILITY_ALERTS = 'no-vulnerability-alerts';
+export const INTERRUPTED = 'interrupted';
 
 // Manager Error
 export const MANAGER_LOCKFILE_ERROR = 'lockfile-error';

lib/manager/bundler/artifacts.ts

@@ -1,5 +1,8 @@
 import { quote } from 'shlex';
-import { BUNDLER_INVALID_CREDENTIALS } from '../../constants/error-messages';
+import {
+  BUNDLER_INVALID_CREDENTIALS,
+  INTERRUPTED,
+} from '../../constants/error-messages';
 import { logger } from '../../logger';
 import { HostRule } from '../../types';
 import * as memCache from '../../util/cache/memory';
@@ -158,6 +161,9 @@ export async function updateArtifacts(
       },
     ];
   } catch (err) /* istanbul ignore next */ {
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     const output = `${String(err.stdout)}\n${String(err.stderr)}`;
     if (
       err.message.includes('fatal: Could not parse object') ||

lib/manager/cargo/artifacts.ts

@@ -1,4 +1,5 @@
 import { quote } from 'shlex';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { logger } from '../../logger';
 import { ExecOptions, exec } from '../../util/exec';
 import {
@@ -105,6 +106,10 @@ export async function updateArtifacts({
       },
     ];
   } catch (err) {
+    // istanbul ignore if
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.warn({ err }, 'Failed to update Cargo lock file');
     return [
       {

lib/manager/cocoapods/artifacts.ts

@@ -1,5 +1,6 @@
 import { quote } from 'shlex';
 import { dirname, join } from 'upath';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { logger } from '../../logger';
 import { ExecOptions, exec } from '../../util/exec';
 import {
@@ -82,6 +83,10 @@ export async function updateArtifacts({
   try {
     await exec(cmd, execOptions);
   } catch (err) {
+    // istanbul ignore if
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     return [
       {
         artifactError: {

lib/manager/composer/artifacts.ts

@@ -3,7 +3,10 @@ import is from '@sindresorhus/is';
 import { quote } from 'shlex';
 import upath from 'upath';
 import { getAdminConfig } from '../../config/admin';
-import { SYSTEM_INSUFFICIENT_DISK_SPACE } from '../../constants/error-messages';
+import {
+  INTERRUPTED,
+  SYSTEM_INSUFFICIENT_DISK_SPACE,
+} from '../../constants/error-messages';
 import {
   PLATFORM_TYPE_GITHUB,
   PLATFORM_TYPE_GITLAB,
@@ -193,6 +196,10 @@ export async function updateArtifacts({
 
     return res;
   } catch (err) {
+    // istanbul ignore if
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     if (
       err.message?.includes(
         'Your requirements could not be resolved to an installable set of packages.'

lib/manager/gomod/artifacts.ts

@@ -1,5 +1,6 @@
 import { quote } from 'shlex';
 import { dirname, join } from 'upath';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { PLATFORM_TYPE_GITHUB } from '../../constants/platforms';
 import { logger } from '../../logger';
 import { ExecOptions, exec } from '../../util/exec';
@@ -154,6 +155,10 @@ export async function updateArtifacts({
     }
     return res;
   } catch (err) {
+    // istanbul ignore if
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.debug({ err }, 'Failed to update go.sum');
     return [
       {

lib/manager/gradle-wrapper/artifacts.ts

@@ -1,5 +1,6 @@
 import { stat } from 'fs-extra';
 import { resolve } from 'upath';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { logger } from '../../logger';
 import { ExecOptions, exec } from '../../util/exec';
 import { readLocalFile, writeLocalFile } from '../../util/fs';
@@ -92,6 +93,10 @@ export async function updateArtifacts({
     try {
       await exec(cmd, execOptions);
     } catch (err) {
+      // istanbul ignore if
+      if (err.message === INTERRUPTED) {
+        throw err;
+      }
       logger.warn(
         { err },
         'Error executing gradle wrapper update command. It can be not a critical one though.'

lib/manager/gradle/index.ts

@@ -1,6 +1,7 @@
 import { Stats } from 'fs';
 import { stat } from 'fs-extra';
 import upath from 'upath';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { LANGUAGE_JAVA } from '../../constants/languages';
 import * as datasourceMaven from '../../datasource/maven';
 import { logger } from '../../logger';
@@ -72,6 +73,9 @@ export async function executeGradle(
     logger.debug({ cmd }, 'Start gradle command');
     ({ stdout, stderr } = await exec(cmd, execOptions));
   } catch (err) /* istanbul ignore next */ {
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     if (err.code === TIMEOUT_CODE) {
       throw new ExternalHostError(err, 'gradle');
     }

lib/manager/helmv3/artifacts.ts

@@ -1,4 +1,5 @@
 import { quote } from 'shlex';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { logger } from '../../logger';
 import { ExecOptions, exec } from '../../util/exec';
 import {
@@ -63,6 +64,10 @@ export async function updateArtifacts({
       },
     ];
   } catch (err) {
+    // istanbul ignore if
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.warn({ err }, 'Failed to update Helm lock file');
     return [
       {

lib/manager/mix/artifacts.ts

@@ -1,4 +1,5 @@
 import { quote } from 'shlex';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { logger } from '../../logger';
 import { exec } from '../../util/exec';
 import { BinarySource } from '../../util/exec/common';
@@ -62,6 +63,10 @@ export async function updateArtifacts({
     const command = [...cmdParts, ...updatedDeps.map(quote)].join(' ');
     await exec(command, { cwd });
   } catch (err) {
+    // istanbul ignore if
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.warn(
       { err, message: err.message },
       'Failed to update Mix lock file'

lib/manager/npm/post-update/lerna.ts

@@ -2,6 +2,7 @@ import semver, { validRange } from 'semver';
 import { quote } from 'shlex';
 import { join } from 'upath';
 import { getAdminConfig } from '../../../config/admin';
+import { INTERRUPTED } from '../../../constants/error-messages';
 import { logger } from '../../../logger';
 import { ExecOptions, exec } from '../../../util/exec';
 import type { PackageFile, PostUpdateConfig } from '../../types';
@@ -113,6 +114,9 @@ export async function generateLockFiles(
     cmd.push(lernaCommand);
     await exec(cmd, execOptions);
   } catch (err) /* istanbul ignore next */ {
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.debug(
       {
         cmd,

lib/manager/npm/post-update/npm.ts

@@ -2,7 +2,10 @@ import { validRange } from 'semver';
 import { quote } from 'shlex';
 import { join } from 'upath';
 import { getAdminConfig } from '../../../config/admin';
-import { SYSTEM_INSUFFICIENT_DISK_SPACE } from '../../../constants/error-messages';
+import {
+  INTERRUPTED,
+  SYSTEM_INSUFFICIENT_DISK_SPACE,
+} from '../../../constants/error-messages';
 import { logger } from '../../../logger';
 import { ExecOptions, exec } from '../../../util/exec';
 import { move, pathExists, readFile, remove } from '../../../util/fs';
@@ -135,6 +138,9 @@ export async function generateLockFile(
     // Read the result
     lockFile = await readFile(join(cwd, filename), 'utf8');
   } catch (err) /* istanbul ignore next */ {
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.debug(
       {
         err,

lib/manager/npm/post-update/pnpm.ts

@@ -2,6 +2,7 @@ import { validRange } from 'semver';
 import { quote } from 'shlex';
 import { join } from 'upath';
 import { getAdminConfig } from '../../../config/admin';
+import { INTERRUPTED } from '../../../constants/error-messages';
 import { logger } from '../../../logger';
 import { ExecOptions, exec } from '../../../util/exec';
 import { readFile, remove } from '../../../util/fs';
@@ -85,6 +86,9 @@ export async function generateLockFile(
     await exec(`${cmd} ${args}`, execOptions);
     lockFile = await readFile(lockFileName, 'utf8');
   } catch (err) /* istanbul ignore next */ {
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.debug(
       {
         cmd,

lib/manager/npm/post-update/yarn.ts

@@ -3,7 +3,10 @@ import { gte, minVersion, validRange } from 'semver';
 import { quote } from 'shlex';
 import { join } from 'upath';
 import { getAdminConfig } from '../../../config/admin';
-import { SYSTEM_INSUFFICIENT_DISK_SPACE } from '../../../constants/error-messages';
+import {
+  INTERRUPTED,
+  SYSTEM_INSUFFICIENT_DISK_SPACE,
+} from '../../../constants/error-messages';
 import { id as npmId } from '../../../datasource/npm';
 import { logger } from '../../../logger';
 import { ExternalHostError } from '../../../types/errors/external-host-error';
@@ -182,6 +185,9 @@ export async function generateLockFile(
     // Read the result
     lockFile = await readFile(lockFileName, 'utf8');
   } catch (err) /* istanbul ignore next */ {
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.debug(
       {
         err,

lib/manager/nuget/artifacts.ts

@@ -1,4 +1,5 @@
 import { join } from 'path';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { id } from '../../datasource/nuget';
 import { logger } from '../../logger';
 import { ExecOptions, exec } from '../../util/exec';
@@ -137,6 +138,10 @@ export async function updateArtifacts({
       },
     ];
   } catch (err) {
+    // istanbul ignore if
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.debug({ err }, 'Failed to generate lock file');
     return [
       {

lib/manager/pip_requirements/artifacts.ts

@@ -1,4 +1,5 @@
 import is from '@sindresorhus/is';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { logger } from '../../logger';
 import { ExecOptions, exec } from '../../util/exec';
 import { readLocalFile } from '../../util/fs';
@@ -52,6 +53,10 @@ export async function updateArtifacts({
       },
     ];
   } catch (err) {
+    // istanbul ignore if
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.debug({ err }, `Failed to update ${packageFileName} file`);
     return [
       {

lib/manager/pipenv/artifacts.ts

@@ -1,4 +1,5 @@
 import { quote } from 'shlex';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { logger } from '../../logger';
 import { ExecOptions, exec } from '../../util/exec';
 import {
@@ -127,6 +128,10 @@ export async function updateArtifacts({
       },
     ];
   } catch (err) {
+    // istanbul ignore if
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.debug({ err }, 'Failed to update Pipfile.lock');
     return [
       {

lib/manager/poetry/artifacts.ts

@@ -1,6 +1,7 @@
 import { parse } from '@iarna/toml';
 import is from '@sindresorhus/is';
 import { quote } from 'shlex';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { logger } from '../../logger';
 import { ExecOptions, exec } from '../../util/exec';
 import {
@@ -153,6 +154,10 @@ export async function updateArtifacts({
       },
     ];
   } catch (err) {
+    // istanbul ignore if
+    if (err.message === INTERRUPTED) {
+      throw err;
+    }
     logger.debug({ err }, `Failed to update ${lockFileName} file`);
     return [
       {

lib/util/exec/exec.spec.ts

@@ -6,6 +6,7 @@ import {
 import { envMock } from '../../../test/exec-util';
 import { setAdminConfig } from '../../config/admin';
 import type { RepoAdminConfig } from '../../config/types';
+import { INTERRUPTED } from '../../constants/error-messages';
 import {
   BinarySource,
   ExecConfig,
@@ -775,4 +776,21 @@ describe(`Child process execution wrapper`, () => {
     );
     expect(removeDockerContainerSpy).toHaveBeenCalledTimes(2);
   });
+  it('converts to INTERRUPTED', async () => {
+    cpExec.mockImplementation(() => {
+      class ErrorSignal extends Error {
+        signal?: string;
+      }
+      const error = new ErrorSignal();
+      error.signal = 'SIGTERM';
+      throw error;
+    });
+    const removeDockerContainerSpy = jest.spyOn(
+      dockerModule,
+      'removeDockerContainer'
+    );
+    const promise = exec('foobar', {});
+    await expect(promise).rejects.toThrow(INTERRUPTED);
+    expect(removeDockerContainerSpy).toHaveBeenCalledTimes(0);
+  });
 });

lib/util/exec/index.ts

@@ -2,6 +2,7 @@ import type { ExecOptions as ChildProcessExecOptions } from 'child_process';
 import { dirname, join } from 'upath';
 import { getAdminConfig } from '../../config/admin';
 import type { RenovateConfig } from '../../config/types';
+import { INTERRUPTED } from '../../constants/error-messages';
 import { logger } from '../../logger';
 import {
   BinarySource,
@@ -157,6 +158,10 @@ export async function exec(
           );
         });
       }
+      if (err.signal === `SIGTERM`) {
+        logger.debug({ err }, 'exec interrupted by SIGTERM');
+        throw new Error(INTERRUPTED);
+      }
       throw err;
     }
     const durationMs = Math.round(Date.now() - startTime);