-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve versioning documentation #9017
docs: improve versioning documentation #9017
Conversation
Copy/pasting @rarkins comment so that we can discuss it here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing versioning for extracted dependencies is not unique to helm-values. Instead we should find an existing versioning documentation page or create a new one that describes how and why you'd want to change versioning, and then in managers like helm-values we can just have a note like "There is no fixed versioning convention for helm charts or the Docker images they reference, so at times the default semver
versioning may not work. Please see X for information of why and how to customize versioning per-dependency."
Turns out we do have a versioning documentation page, but it's hidden behind a fold-out menu: Renovate docs -> Renovate Modules -> Versioning. The sub-section are coming from https://github.com/renovatebot/renovate/tree/master/lib/versioning and sourced from
I agree we should probably centralize the versioning information, instead of spreading it over a lot of sub-pages. 😄 |
If you think fold-out menus can be removed and users would benefit from showing all sub-options by default, then we can do that (or perhaps wait until the Docusaurus migration is done). The "Configuring Versioning" section is kind of what I had in mind (I'd forgotten it existed). Let's improve it if necessary and then link to it from managers with inconsistent versioning conventions - especially Docker ones.
The sub-menus are for versioning schemes (lib/versioning/) while |
I think that showing the sub-options might be a good stop-gap for now, as that allows users to "stumble upon" something they don't yet know they want/need. I've checked the Docusaurus v2 docs, and you can select which sub-pages it should fold/display in the sidebar: https://v2.docusaurus.io/docs/sidebar#expanded-categories-by-default
I'll go tinker with this PR to improve the existing "configuring versioning" section then. 😉
Okay, so that's not the right place, I'll stay away from doing things in this folder then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Improve https://github.com/renovatebot/renovate/blob/master/docs/usage/modules/versioning.md to make it clearer why/how versioning might need a manual setting
- Reduce the text in helm-values/readme.md and replace with a more generic statement.
- Add same generic statement to other managers which have a similar requirement (mostly docker-related ones which don't enforce semver)
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
We still need to do the last thing in this list: "Add same generic statement to other managers which have a similar requirement". @rarkins Is there a list somewhere of those manager which are likely to need custom versioning as well? So that we can copy/paste the generic statement into their manager docs? |
It's only really ones in the Docker ecosystem for now - e.g. dockerfile, docker-compose |
@rarkins I hope these are OK, I tried to determine if it's likely that you'll need to override the default versioning. I saw some other managers that also don't seem to follow SemVer, so I included those as well. Feel free to suggest changes. 😉 |
🎉 This PR is included in version 24.96.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thanks for helping me out here, and for merging the work! 😄 ✨ |
Changes:
Goals of the rewrite as stated by @rarkins:
semver
)Context:
We need to improve our documentation so that we're clearer on how to configure custom versioning, and why you would want/need to do that.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: