fix(azure): Fix additional argument for getRawFile #9450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
approved these changes
Apr 8, 2021
|
|
||
| let repoId: string; | ||
| if (repoName) { | ||
| const repos = await azureApiGit.getRepositories(); |
There was a problem hiding this comment.
Maybe cache this in config or defaults
|
🎉 This PR is included in version 24.107.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Current behavior worked just because of
config.repoIddefault parameter. In the case when the second parameter ofgetRawFileis actually used, we need discover this repo ID first.Context:
Probably, the better way is to call
azureGitApi.getRepositories()in theinitPlatform()and store result locally instead of 2–3 more occasional calls from other platform methods. Moreover, it's desirable to check the credentials somehow in theinitPlatform()phase, which can be done via repo discovery. Hovewer, it requires pretty substantial refactoring of tests that would block #9171. So, this PR is good enough kind of solution allowing us to release local plugins support first.Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: