-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow multiple autodiscover filter #9453
Conversation
1deb3da
to
d11739c
Compare
d11739c
to
a0e7944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config definition needs update too, see schedule
as sample.
renovate/lib/config/definitions.ts
Line 563 in 20147e3
type: 'string', |
Also needs a migration for compatibility, see baseBranch
as sample
renovate/lib/config/migration.ts
Line 359 in edfac73
migratedConfig.baseBranches = (is.array(val) ? val : [val]) as string[]; |
|
Would it work if you defined it as allowStrong=true in definitions? That way massaging might happen automatically and massaging isn't required. |
What do you mean by defining it as |
Check |
a0e7944
to
7aba1ef
Compare
Oh, I'm sorry 😅 I've added |
Did you tested a single string too for |
ok i see this renovate/lib/config/massage.ts Lines 12 to 19 in 3357e63
renovate/lib/config/massage.ts Lines 22 to 23 in 3357e63
So it should work, because all configs are passed to this |
2a3cb9b
to
b1992b0
Compare
b1992b0
to
eb737c8
Compare
To support multiple filters when using the autodiscover feature, the type of the configuration value is changed to an array. Closes renovatebot#8763 BREAKING CHANGE: The type of the 'autodiscoverFilter' configuration value has changed to an string array.
b4bf1be
to
d25b498
Compare
🎉 This PR is included in version 24.118.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
To support multiple filters when using the autodiscover feature, the
type of the configuration value is changed to an array.
Closes #8763
Changes:
Type of
autodiscoverFilter
configuration value changed tostring[]
.Context:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: