Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate git version #9979

Merged
merged 11 commits into from
May 21, 2021
Merged

feat: validate git version #9979

merged 11 commits into from
May 21, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented May 12, 2021

Changes:

Updates development docs and adds a test

Context:

Helpful for #9938

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice May 12, 2021 15:49
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also log as warning at runtime? So if a user is using a custom docker image or the plain npm package?

lib/util/git/index.spec.ts Outdated Show resolved Hide resolved
@rarkins rarkins marked this pull request as draft May 13, 2021 08:23
@rarkins rarkins marked this pull request as ready for review May 16, 2021 09:30
@rarkins rarkins requested a review from viceice May 16, 2021 19:59
@rarkins rarkins marked this pull request as draft May 16, 2021 20:31
@rarkins rarkins changed the title chore: test git version feat: validate git version May 16, 2021
const globalGit = Git();
try {
const raw = await globalGit.raw(['--version']);
console.warn(raw); // eslint-disable-line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? Leftover from testing?

@rarkins rarkins marked this pull request as ready for review May 21, 2021 13:50
@rarkins rarkins enabled auto-merge (squash) May 21, 2021 19:38
@rarkins rarkins merged commit 1304bc9 into main May 21, 2021
@rarkins rarkins deleted the chore/min-git-version branch May 21, 2021 19:51
rarkins added a commit that referenced this pull request May 22, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants