chore: try spike/search-preview-2 (do not merge) #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonkingGoose
changed the title
|
Please check squidfunk/mkdocs-material#6372 – it implements a new ranking method. Feedback appreciated. Also, if your problem is still not solved, a minimal reproduction would be perfect, so we have something for testing |
HonkingGoose
changed the title
|
@HonkingGoose Can you please fix the conflicts? |
HonkingGoose
force-pushed
the
chore/try-new-search
branch
from
27040b3
to
27c6135
Compare
|
I'll fix the conflicts, and get us current with |
|
Keeping this PR current with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
spike/search-preview-2branch from upstream Material for MkDocsContext:
The
spike/search-preview-*branches won't get merged upstream, it's just to gather feedback. So we shouldn't merge this PR. I'm marking this PR as draft to prevent accidental merges into production.I tried some searches on the spike 1 preview, and it seems the same as our current search. I used the
pipenv install git+https://github.com/squidfunk/mkdocs-material.git@spike/search-preview-1command to install the search preview, and then ranmake serveto try the new search.Searches with the
spike/search-preview-2package are different. I don't know if it's better or worse yet.Related issue: