Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/subnets #136

Merged
merged 17 commits into from Jun 23, 2022
Merged

Feat/subnets #136

merged 17 commits into from Jun 23, 2022

Conversation

susruth
Copy link
Contributor

@susruth susruth commented Jun 22, 2022

Description

Adding support for subnets, and slashing to the Darknode Registry

Motivation

We need subnets and slashing features to pave way for the Ren L1 launch

Design

We are adding support for 255 subnets by using a uint256 value, where each of the bit corresponds to the inclusion/exclusion of a specific darknode in a subnet.

We created a simple slasher that would allow honest darknodes to slash malicious darknodes by creating and submitting a signature.

  • What packages that will be affected by this change? (Related work)

We updated DarknodeRegistryLogicV2 and DarknodeRegistryStateV2 (in DarknodeRegistry.sol) to add subnet support.

We created a Slasher.sol that allows RenVM to submit signatures to slash malicious darknodes.

  • What PRs will be affected by this change? (Related work)

PR #133

Unresolved Issues

Overall simplification and rewrite, conversion to hardhat and upgrading to the latest solidity versions

@susruth susruth requested a review from 0x31 June 22, 2022 06:30
contracts/slasher/Slasher.sol Outdated Show resolved Hide resolved
contracts/slasher/Slasher.sol Outdated Show resolved Hide resolved
contracts/slasher/Slasher.sol Outdated Show resolved Hide resolved
@susruth susruth merged commit 93a4f78 into release/1.2.1 Jun 23, 2022
@susruth susruth deleted the feat/subnets branch June 23, 2022 05:58
@susruth susruth mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants