New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/subnets #136
Merged
Merged
Feat/subnets #136
+442
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comunidadio
reviewed
Jun 22, 2022
comunidadio
reviewed
Jun 22, 2022
0x31
reviewed
Jun 23, 2022
0x31
approved these changes
Jun 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for subnets, and slashing to the Darknode Registry
Motivation
We need subnets and slashing features to pave way for the Ren L1 launch
Design
We are adding support for 255 subnets by using a uint256 value, where each of the bit corresponds to the inclusion/exclusion of a specific darknode in a subnet.
We created a simple slasher that would allow honest darknodes to slash malicious darknodes by creating and submitting a signature.
We updated DarknodeRegistryLogicV2 and DarknodeRegistryStateV2 (in DarknodeRegistry.sol) to add subnet support.
We created a Slasher.sol that allows RenVM to submit signatures to slash malicious darknodes.
PR #133
Unresolved Issues
Overall simplification and rewrite, conversion to hardhat and upgrading to the latest solidity versions