withdrawMultiple, darknodeBalances #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinceau
suggested changes
May 6, 2019
vinceau
reviewed
May 6, 2019
| await linkedList.insertBefore(NODE1, NULL).should.not.be.rejected; | ||
| await linkedList.remove(NULL).should.not.be.rejected; | ||
| await linkedList.insertBefore(NODE1, NULL); | ||
| await linkedList.remove(NULL); |
There was a problem hiding this comment.
Why are the non-rejection assertions removed?
There was a problem hiding this comment.
Are they useful? It throws anyway, and it still doesn't give the line number.
There was a problem hiding this comment.
What's the motivation for removing them? I feel like the test is much clearer if there is an assertion.
vinceau
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two functions to the Darknode Payments contract:
withdrawMultipleanddarknodeBalances.Motivation
withdrawMultiple: This allows users to withdraw multiple tokens with a single transaction.darknodeBalances: This allows retriving darknode reward balances without having to know about the store.