Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the Shifter to transfer the ownership of its token #66

Merged
merged 4 commits into from Jul 3, 2019

Conversation

0x31
Copy link
Contributor

@0x31 0x31 commented Jul 3, 2019

This PR allow the Shifter to transfer the ownership of its token. This means we can deploy a new shifter contract without deploying a new token as well.

The PR addresses issues brought up in #64 after it was merged.

Tests for this have been added (back) here.

Some lint issues have been resolved as well.

@0x31 0x31 requested review from susruth and loongy July 3, 2019 06:00
Copy link
Contributor

@loongy loongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loongy loongy merged commit 9aa41e4 into master Jul 3, 2019
@loongy loongy deleted the shifter-transfer-token branch July 3, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants