Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart process timer on boot #38

Merged
merged 9 commits into from
Mar 11, 2020
Merged

Restart process timer on boot #38

merged 9 commits into from
Mar 11, 2020

Conversation

tok-kkk
Copy link
Member

@tok-kkk tok-kkk commented Jan 29, 2020

Process will start a timer when first time receives 2f+1 prevotes/precommits. If the process stops before the timer expires, it will not start a new timer when restarting, this could cause process stuck in prevote/precommit step and never move on.

@jazg jazg added the bug Something isn't working label Jan 30, 2020
@jazg jazg changed the base branch from master to release/0.2.0 March 10, 2020 00:38
@jazg jazg changed the base branch from release/0.2.0 to release/1.1.0 March 10, 2020 00:40
Copy link
Contributor

@loongy loongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a regression test that fails before this change, and passes after it?

@jazg jazg changed the title [WIP] Fix process not start the timer when restarting Restart Process timer on boot Mar 10, 2020
@jazg jazg changed the title Restart Process timer on boot Restart process timer on boot Mar 10, 2020
@jazg jazg force-pushed the fix/re-schedule branch 6 times, most recently from 39eb0ff to 95da57f Compare March 11, 2020 00:36
Copy link
Contributor

@loongy loongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jazg jazg merged commit ae4f0e3 into release/1.1.0 Mar 11, 2020
@jazg jazg deleted the fix/re-schedule branch March 11, 2020 03:13
@jazg jazg mentioned this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants