Optimism support #153
Merged
Optimism support #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdsoumya
reviewed
Jun 28, 2022
| @@ -183,7 +183,7 @@ func (tx *Tx) Sign(signatures []pack.Bytes65, pubKey pack.Bytes) error { | |||
| continue | |||
| } | |||
| } else { | |||
| if txscript.IsPayToWitnessScriptHash(sigScript) || txscript.IsPayToWitnessScriptHash(sigScript) { | |||
| if txscript.IsPayToWitnessPubKeyHash(sigScript) || txscript.IsPayToWitnessScriptHash(sigScript) { | |||
There was a problem hiding this comment.
I probably don't have the context but was our old bitcoin implementation broken?
There was a problem hiding this comment.
It didn't affect our internal usage, but may have affected external users since that particular branch wasn't being handled.
Comment on lines
+61
to
+75
| case []pack.U256: | ||
| v := make([]*big.Int, len(val)) | ||
| for i := range val { | ||
| elem, ok := big.NewInt(0).SetString(val[i].String(), 10) | ||
| if !ok { | ||
| panic(fmt.Errorf("encoding list item: %v", err)) | ||
| } | ||
| v[i] = elem | ||
| } | ||
| ethval = v | ||
| ty, err = abi.NewType("uint256[]", "", nil) | ||
| case []Address: | ||
| ethval = val | ||
| ty, err = abi.NewType("address[]", "", nil) | ||
|
|
There was a problem hiding this comment.
are these optimism specific or did we never face such type of params before?
There was a problem hiding this comment.
Nope, these are specific to some new slashing contracts being built. We should add support for even more types when we can!
gdsoumya
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.