Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing the Ren'Py window stops any playing movie #12

Closed
davey3000 opened this issue Aug 7, 2012 · 1 comment
Closed

Resizing the Ren'Py window stops any playing movie #12

davey3000 opened this issue Aug 7, 2012 · 1 comment
Assignees
Milestone

Comments

@davey3000
Copy link

Resizing the Ren'Py window (either using the resize control at the bottom right of the window or using the preferences screen to switch between window and fullscreen displays) causes any movie currently playing in Ren'Py to stop without restarting.

A testcase for this bug is to create a new project, provide a sample video file "test_movie.webm" and set script.rpy to:

# Test script
init:
  image movie = Movie (size=(config.screen_width, config.screen_height), xalign=0.0, yalign=0.0)

label start:
  scene black
  show movie

  play movie "test_movie.webm"

  "Is it still playing?"

  stop movie
  hide movie

  return

The video format does not appear to make a difference. Tested with a WebM (VP8 + Vorbis) video and a Matroska (Theora + Vorbis) video.

Possibly related: running on Linux, the following message was dumped to the console when switching between window and full screen displays:

OpenGL Warning: glXChooseVisual: ignoring attribute 0x22

Issue observed in Ren'Py build 6.14.0.329 on platforms Ubuntu 12.04 LTS 32-bit and Windows 7 64-bit.

@ghost ghost assigned renpytom Aug 9, 2012
@renpytom
Copy link
Member

renpytom commented Aug 9, 2012

I've fixed this code so that the only time movie play stops is when the user toggles fullscreen mode on the software renderer. The movie stop code was an artifact of a time when the software renderer was the only renderer - stopping the movie is necessary to prevent Ren'Py from writing to a surface that's about to no longer exist.

In GL-based renderers, it was never necessary to stop the movie, so we no longer do so.

The fix will be in the next 6.14 pre-release, which I'm hoping will be out tomorrow.

@renpytom renpytom closed this as completed Aug 9, 2012
renpytom pushed a commit that referenced this issue May 8, 2019
Keep going to latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants