Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_history_list.voice.filename will be None if Voice Sustain is on #1228

Closed
zedraxlo opened this issue Aug 23, 2017 · 7 comments
Closed

_history_list.voice.filename will be None if Voice Sustain is on #1228

zedraxlo opened this issue Aug 23, 2017 · 7 comments

Comments

@zedraxlo
Copy link
Contributor

When Voice Sustain opened, then:
for h in _history_list:
h.voice.filename will return None in any case.

@zedraxlo
Copy link
Contributor Author

zedraxlo commented Sep 15, 2017

This time, with 6.99.13.2758:
The sentences with no voice will all return _last_voice_play which should return None
@renpytom

@renpytom renpytom reopened this Sep 16, 2017
@renpytom
Copy link
Member

Please reopen an issue when you add a comment like this, so I can find it more easily.

@zedraxlo
Copy link
Contributor Author

Sorry, I'm a newer to Github and didn't find the reopen button

@renpytom
Copy link
Member

No problem, it's just to let you know for the future, since I lost this bug and thought I was going crazy since I remembered it.

@zedraxlo
Copy link
Contributor Author

@renpytom
They get back to return all None after 6.99.13.2770
for reopen the issue, I found this:
"you cannot re-open your own issues if a repo collaborator closed them"

@renpytom
Copy link
Member

The problem here is that there are no

@renpytom renpytom reopened this Sep 19, 2017
renpytom added a commit that referenced this issue Sep 20, 2017
@renpytom
Copy link
Member

Okay, so I've thought about how this should work, and this is what I settled on.

h.voice.filename is set on initial play, or if the script explicitly says the voice should be sustained. It's not set if the voice sustain preference is set, since that means that voice would be sustained forever.

Hopefully, this should give a reasonable behavior for every game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants