Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing Italian translations and add missing ones #5486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrigamerita
Copy link

@andrigamerita andrigamerita commented Apr 28, 2024

Hello again everyone, this time I decided I would contribute something to Ren'Py!
My initial idea was to work on translating both of the example novels included with the SDK, since I was surprised to see that they aren't available in my native language, Italian. However, after starting to work on them, I noticed how many strings from the engine were not properly translated: a few were missing here and there, some had a few inconsistencies or slightly bad word forms, and quite a big chunk were of really low quality due to being machine-translated. So, here I got to work:

  • Updating and improving the Italian translation for the engine template and launcher
    • Checking and revising all translations marked as automatic (then unmarking them)
    • Slightly revising the existing manual translations (correcting inconsistent capitalization and unnatural word forms)
    • Creating translations for entirely missing strings
  • [ ] Translating example and tutorial novels to Italian (will be moved to distinct PRs)
    * [ ] The Question
    * [ ] Tutorial (this will probably take a while, but I think it's a good chance to study Ren'Py better)

You might have noticed that I've sent this as a draft PR. What I've already checked on the list is effectively completed, but I thought of making a single pull request for everything since that's probably easier to manage. If that's okay with you, I will first complete everything on the to-do list, and then mark this request as completed, so that you can then merge; otherwise, I will split what is still missing at time of writing into separate PRs. If you have any comments about my contribution, or if you think there are things to fix in it, please let me know as soon as you see fit!

@renpytom
Copy link
Member

Thank you!

You're right, newer strings were machine-translated, to keep the translation from falling completely out of date. So I appreciate the work.

I'd suggest breaking it up into 3 PRs - engine/launcher, and then the two games. That's because people and projects will benefit immediately from the engine translation. There's no need to wait for the others to be finished.

@andrigamerita
Copy link
Author

I'd suggest breaking it up into 3 PRs - engine/launcher, and then the two games. That's because people and projects will benefit immediately from the engine translation. There's no need to wait for the others to be finished.

Yeah, that makes sense. I''ll strikethrough the incomplete points on this list then, take the PR out of the draft status, and send those other two PRs when I've started and finished working on them!

@andrigamerita andrigamerita marked this pull request as ready for review April 28, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants