Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails #27

Closed
Tey opened this issue Apr 10, 2022 · 1 comment · Fixed by #28
Closed

Build fails #27

Tey opened this issue Apr 10, 2022 · 1 comment · Fixed by #28

Comments

@Tey
Copy link
Contributor

Tey commented Apr 10, 2022

cp ~/ab/renpy-build/renpyweb/ceval.c Python/ceval.c

Building renpyweb fails because of the absolute path there. Replacing ~/ab/renpy-build/renpyweb/ceval.c with ../../../../ceval.c Python/ceval.c does the trick for me, but maybe the root path to renpyweb should be retrieved using an environment variable instead?

On a side note, there are lots of references to /home/tom/ab in the build scripts, but they do not prevent building renpyweb:

Details
ubuntu@test:~/renpyweb/renpy-build$ egrep -r '/(tom|ab)/' .
./nightly/build.sh:cp /home/tom/ab/renpy-deps/scripts/README.nightly /home/tom/ab/WWW.nightly/README.txt
./nightly/build.sh:. /home/tom/.virtualenvs/nightlyrenpy/bin/activate
./nightly/build.sh:link /home/tom/ab/WWW.nightly dl
./nightly/build.sh:link /home/tom/ab/renpy/atom atom
./nightly/build.sh:link /home/tom/ab/renpy/jedit jedit
./nightly/build.sh:link /home/tom/ab/renpy/editra editra
./nightly/nightly_email.py:#!/home/tom/.virtualenvs/renpy/bin/python
./nightly/nightly_email.py:        rv = subprocess.call([ "nice", "./nightly.sh", '/home/tom/ab/nightly-build/', "--upload", "--prune" ], stdout=f, stderr=f)
./nightly/web.sh:    rsync -e "$SSH" --progress -av /home/tom/magnetic/ab/WWW.nightly/ tom@abagail.onegeek.org:/home/tom/WWW.nightly
./nightly/web.sh:$SCRIPTS/index_nightly.py /home/tom/magnetic/ab/WWW.nightly/
./nightly/web.sh:    rsync -e "$SSH" --progress -av /home/tom/magnetic/ab/WWW.nightly/ tom@abagail.onegeek.org:/home/tom/WWW.nightly --delete
./nightly/web.sh:    find /home/tom/magnetic/ab/WWW.nightly/ -ctime +30.5 -delete || true
./rapt/buildlib/rapt/iconmaker.py:    im = IconMaker("/home/tom/ab/renpy/the_question")
Binary file ./rapt/prototype/.idea/caches/gradle_models.ser matches
./run_ios.sh:pushd /Volumes/shared/ab/renpy-build/renios/prototype
./test_android.sh:ln -s "/home/tom/ab/android/Sdk" "$ROOT/renpy/rapt/Sdk"
./test_android.sh:cp -a /home/tom/ab/keys/local.properties "$ROOT/renpy/rapt/project"
./test_android.sh:cp -a /home/tom/ab/keys/bundle.properties "$ROOT/renpy/rapt/project"
./test_ios.sh:rsync -a --delete --exclude '*.xcodeproj' /tmp/ios-test tom@mary21.local:/Users/tom/ios
./test_mac.sh:    rsync -a /home/tom/ab/renpy-build/renpy/$1 $mac:$path/$2
./test_nightly.sh:nightly=${NIGHTLY:-/home/tom/ab/nightly-build}
./renpy/add.py:    "/home/tom/ab/renpy",
./renpy/add.py:    "/home/tom/ab/renpy-build",
./renpy/add.py:    "/home/tom/ab/pygame_sdl2",
./renpy/add.py:    "/home/tom/ab/renpy-build/renpyweb",
./renpy/add.py:    subprocess.check_call([ "/home/tom/ab/renpy/scripts/checksums.py", "/home/tom/ab/renpy/dl/" + short_version ])
./renpy/add.py:os.chdir("/home/tom/ab/renpy/dl")
./renpy/add.py:os.chdir("/home/tom/ab/website")
./renpy/add.py:os.chdir("/home/tom/ab/renpy/sphinx")
./renpy/distribute.py:#!/home/tom/ab/renpy/lib/py2-linux-x86_64/python -O
./renpy/distribute.py:            "/home/tom/ab/keys/renpy_private.pem",
./renpy/sphinx/source/chromeos.rst:    cd ~/ab/renpy-7.4.0-sdk
./renpy/sphinx/upload.sh:rsync -a ../doc-web/ tom@abagail.onegeek.org:/home/tom/WWW.renpyorg/doc/html/
./renpy/sphinx/upload_dev.sh:rsync -va ../doc-web/ tom@abagail.onegeek.org:/home/tom/WWW.renpyorg/dev-doc/html/
./pygame_sdl2/scripts/build_all.sh:cd "/home/tom/ab/$PROJECT"
./pygame_sdl2/scripts/build_all.sh:"$SCRIPT/run_win.py" /t/ab/pygame_sdl2/scripts/build_win.sh "$PROJECT" "$SUFFIX"
./pygame_sdl2/scripts/build_nightly.sh:WWW=/home/tom/magnetic/ab/WWW.nightly
./pygame_sdl2/scripts/build_nightly.sh:rm -Rf "/home/tom/ab/$PROJECT" || true
./pygame_sdl2/scripts/build_nightly.sh:git clone https://github.com/renpy/pygame_sdl2 "/home/tom/ab/$PROJECT"
./pygame_sdl2/scripts/build_nightly.sh:cd "/home/tom/ab/$PROJECT"
./pygame_sdl2/scripts/build_nightly.sh:rsync -av /home/tom/magnetic/ab/WWW.nightly/pygame_sdl2/ tom@erika.onegeek.org:/home/tom/WWW.nightly/pygame_sdl2 --delete
./pygame_sdl2/scripts/build_nightly.sh:find /home/tom/magnetic/ab/WWW.nightly/pygame_sdl2/ -ctime +30 -delete
./pygame_sdl2/scripts/build_win.sh:cd "/t/ab/$PROJECT"
./renpyweb/python-emscripten/2.7.18/python.sh:    #FIXME cp ~/ab/renpy-build/renpyweb/ceval.c Python/ceval.c
@renpytom
Copy link
Member

Hopefully after your fix, the absolute paths are limited to tests, nightly builds, and release. I'll audit these when I get a chance, though some of these might be a bit of a pain to fix. They're a good catch, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants