Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python script to add VSCode no longer needed #145

Closed
duckdoom4 opened this issue Jun 16, 2022 · 4 comments · Fixed by #156
Closed

Python script to add VSCode no longer needed #145

duckdoom4 opened this issue Jun 16, 2022 · 4 comments · Fixed by #156
Milestone

Comments

@duckdoom4
Copy link
Collaborator

duckdoom4 commented Jun 16, 2022

Am I correct in that this script is no longer needed since @renpytom has integrated it into the launcher already?

If that's the case I would suggest removing the file and the section in the readme

@LuqueDaniel
Copy link
Member

It was added so that users with older versions of Ren'Py could integrate the editor with their projects.

Should we keep it? maybe we could move it to a code block inside the readme.

@duckdoom4
Copy link
Collaborator Author

In that case we should at least edit the readme to make it clear this is intended for older users

@renpytom
Copy link
Member

I'd suggest waiting for the final release of 7.5, when that happens.

@LuqueDaniel
Copy link
Member

Ok, when version 7.5 is released we'll edit the readme to clarify that it's only required in versions <7.5.

@duckdoom4 duckdoom4 added the todo label Jun 22, 2022
LuqueDaniel pushed a commit that referenced this issue Jul 2, 2022
* Updated README.md
closes #145
Made note that latest version of renpy includes VSCode
@LuqueDaniel LuqueDaniel added this to the 2.0.12 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants