Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support named stores #40

Merged
merged 8 commits into from
Oct 31, 2021
Merged

Support named stores #40

merged 8 commits into from
Oct 31, 2021

Conversation

rdurfee
Copy link
Collaborator

@rdurfee rdurfee commented Oct 25, 2021

Support Named Stores for autocompletion and semantic highlighting #38

Support Named Stores for autocompletion and semantic highlighting renpy#38
@multimokia
Copy link
Contributor

image
image

Noticing that stores from early don't show up:
image

@LuqueDaniel LuqueDaniel added this to the Next release milestone Oct 25, 2021
@LuqueDaniel
Copy link
Member

@rdurfee Let me know when it's ready to be merged 😄

Fix class variables not highlighting or showing in completion list renpy#46

Fix inherited classes not showing completion parameters renpy#45
Fix regex warning
@rdurfee
Copy link
Collaborator Author

rdurfee commented Oct 29, 2021

@LuqueDaniel I didn't realize it was going to put the two merges into one PR! But these should be good to go now.

@LuqueDaniel LuqueDaniel self-requested a review October 30, 2021 13:08
Copy link
Member

@LuqueDaniel LuqueDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdurfee I like it. Can you add the changes from this PR to the changelog?

Update changelog for next release
Copy link
Member

@LuqueDaniel LuqueDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants