Can icons props be optionnal?

[DryDemon]

on line 122 in index.d.ts there is the icon props
icons: { search: { name: string size: number } ....
Is it possible to set icons as an optional variable? I don't need to change the default setting.
icons: { to icons?: {

[itzfeltrin]

yes, please. also, the 'IconRenderer' prop expects a function when it should be just an element. it works fine like this, but the error is annoying me :x

[renrizzolo]

Is this wrong? What should it be?

react-native-sectioned-multi-select/index.d.ts

Line 116 in 068ce82

IconRenderer?: (() => void) | JSX.Element

[itzfeltrin]

I don't know, really, just got started with ts. maybe something changed with rn-vector-icons?. I will take a look into that later. anyway, I'd appreciate if you could make the icons prop optional :)

[itzfeltrin]

adding React.ReactNode to the IconRenderer prop makes the error go away, I don't know if it's a good solution tho

[scousino]

the real issue is with the icons prop, not the IconRenderer prop. icons is currently listed as a required prop, but it isn't required, since a default is available.

[scousino]

To clarify the IconRenderer typescript error is also valid, just not what the original poster was opening the issue about.

[JimTeva]

@renrizzolo , please check #253

[renrizzolo]

Both issues should be ixed in v0.8.2, please re-open if it persists.

[jonrainier]

9cc4df7#diff-7aa4473ede4abd9ec099e87fec67fd57afafaf39e05d493ab4533acc38547eb8L124

Looks like these changes were reverted in this commit. Not sure if it's intentional or not, but I'm running into the same issues previously mentioned in this thread.