Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "colorama" package to latest #192

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

barbossa
Copy link

@barbossa barbossa commented Jul 25, 2020

Latest version of colorama is 0.4.3 https://pypi.org/project/colorama/.

@barbossa
Copy link
Author

@renskiy hello, can you look at this PR and if everything is ok, please merge it

@renskiy
Copy link
Owner

renskiy commented Jul 26, 2020

@barbossa looks good for me. But can you explain why you need newer version of colorama?

@barbossa
Copy link
Author

@barbossa looks good for me. But can you explain why you need newer version of colorama?

In my project I have unresolved dependency for "colorama" that broke updating pre-commit to newer version.

New version of pre-commit requires colorama>0.4, but fabricio has colorama<0.4. By this reason I cannot update pre-commit.

@@ -4,8 +4,6 @@ sudo: false

python:
- "2.7"
- "3.4"
- "3.5"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version of Colorama does support Python 3.5. Are you sure about this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renskiy you're right, we should support Python 3.5.

I've made an additional commit and returned Python 3.5 to travis.

Copy link
Author

@barbossa barbossa Jul 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, but I've forgot do the same with fabricio doc. Need one more commit 🙂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renskiy I think you should make squash commits before merging and combine my 7 commits into 1.

Github interface should support squashing before merging.

changelog.rst Outdated
@@ -1,6 +1,12 @@
Changelog
=========

Release 0.5.9
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compatibility-breaking changes should increase major version too. I think it will 0.6 after all

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renskiy done.

@barbossa
Copy link
Author

barbossa commented Aug 8, 2020

@renskiy hey, do you plan merge this MR? 🙂

@renskiy
Copy link
Owner

renskiy commented Aug 8, 2020

@barbossa yes, next week

@renskiy
Copy link
Owner

renskiy commented Sep 8, 2020

@barbossa hi, sorry for delay. But I actually have not decided to make new version yet. But your PR will be in this version when it will be released.

Speaking about dependencies and dependency conflicts I think you should not mix Fabricio environment (AKA deploy environment) and your project code environment. There are many version conflicts will be if such mixing take place.

To solve your issue you can install Fabricio in another environment. Installation process will add fab executable to the current environment. And you should do one of the following things after that:

  • update your PATH environment variable which will include path to selected environment binaries
  • or you could install fabricio to your system default python environment, then fab will be available immediately
    after install

@barbossa
Copy link
Author

@renskiy hey. Don't worry about late response, everything is ok 🙂 I I've figure out my issue, I use fork of fabricio with fixed dependency conflicts. I can wait while you do release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants