Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Updates to Documentation #94

Open
jgrubard opened this issue Aug 6, 2020 · 1 comment
Open

Minor Updates to Documentation #94

jgrubard opened this issue Aug 6, 2020 · 1 comment
Labels
docs Update the documentation site.

Comments

@jgrubard
Copy link
Collaborator

jgrubard commented Aug 6, 2020

Just a few comments -- nothing crazy:

https://design.avail.co/packages/tag
import Tag, { FilterTag } from "@rent_avail/tooltip"
should be
import Tag, { FilterTag } from "@rent_avail/tag"

https://design.avail.co/packages/input
import { Input } from "@rent_avail/input"
should be
import Input from "@rent_avail/input"

https://design.avail.co/packages/controls
should indicate loading prop will not work if button is disabled

@pkrawc
Copy link
Collaborator

pkrawc commented Aug 6, 2020

These are good updates.

For the third one, it's really that loading disables the button while spinning (it'll prevent multiple submit actions from occurring). But yeah, that should be called out.

@pkrawc pkrawc added the docs Update the documentation site. label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Update the documentation site.
Projects
None yet
Development

No branches or pull requests

2 participants