🏭 Standardize.

Callables (lower case) imported must be qualified. Classes (upper case) imported must not be qualified.
rentruewang · Nov 14, 2023 · b60d94c · b60d94c
1 parent a17abc9
commit b60d94c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/perbert/data/collators.py b/perbert/data/collators.py
@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from abc import abstractmethod
+import abc
 from typing import Any, Dict, List, Protocol, Type
 
 from transformers import DataCollatorForLanguageModeling, DataCollatorForWholeWordMask
@@ -9,7 +9,7 @@
 
 
 class Collator(Protocol):
-    @abstractmethod
+    @abc.abstractmethod
     def __call__(self, encodings: List[Dict[str, Any]]) -> Dict[str, Any]:
         ...
 

diff --git a/perbert/data/datasets/mappers.py b/perbert/data/datasets/mappers.py
@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from abc import abstractmethod
+import abc
 from typing import Any, Callable, Dict, List, Protocol, TypeVar
 
 import loguru
@@ -12,7 +12,7 @@
 
 
 class Mappable(Protocol):
-    @abstractmethod
+    @abc.abstractmethod
     def filter(
         self,
         function: Callable[[Any], Any],
@@ -26,7 +26,7 @@ def filter(
     ) -> Self:
         ...
 
-    @abstractmethod
+    @abc.abstractmethod
     def map(
         self,
         function: Callable[[Any], Any],
@@ -42,11 +42,11 @@ def map(
         ...
 
     @property
-    @abstractmethod
+    @abc.abstractmethod
     def column_names(self) -> List[str] | Dict[str, List[str]]:
         ...
 
-    @abstractmethod
+    @abc.abstractmethod
     def remove_columns(self, column_names: str | List[str]) -> Self:
         ...
 
@@ -68,11 +68,11 @@ def _flat_column_names(mapper: Mappable) -> List[str]:
 
 
 class Mapper(Protocol[T]):
-    @abstractmethod
+    @abc.abstractmethod
     def __init__(self, cfg: DictConfig, mapper: T) -> None:
         ...
 
-    @abstractmethod
+    @abc.abstractmethod
     def apply(self) -> T:
         ...
 

diff --git a/perbert/data/datasets/wrappers.py b/perbert/data/datasets/wrappers.py
@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from abc import abstractmethod
+import abc
 from typing import Dict, Generic, Protocol, Sized, TypeVar
 
 import loguru
@@ -22,12 +22,12 @@
 class Indexible(Protocol[K, V]):
     "Indexible type implements both `__len__` and `__getitem__`"
 
-    @abstractmethod
+    @abc.abstractmethod
     def __len__(self) -> int:
         "self.__len__() <==> len(self)"
         ...
 
-    @abstractmethod
+    @abc.abstractmethod
     def __getitem__(self, key: K) -> V:
         "self.__getitem__(key) <==> self[key]"