Skip to content
This repository

Breaks with transformable properties #89

Closed
danielctull opened this Issue January 26, 2012 · 11 comments

5 participants

Daniel Tull Jonathan 'Wolf' Rentzsch Stephan Michels Jacob Gorban Stanley Rost
Daniel Tull

At the moment transformable properties are being generated like as so @property (nonatomic, strong) idcolor; with no space between the type and identifier.

Two solutions to this seem to be:

  • Change -objectAttributeType to return @"id " instead of @"id"
  • Add a check in the template <$if Attribute.hasTransformableAttributeType$> <$endif$> to add the space

I'm not sure which it should be, I believe this is part of changes @robrix made, so I'm not sure what side affects changing the return from that method may cause.

Daniel Tull

Either of those commits resolve this issue, I'm currently running with changing the template for safety. :)

Jonathan 'Wolf' Rentzsch
Owner

Right you are, I intend to make transformable property class output smarter as detailed in #86 (comment)

Jonathan 'Wolf' Rentzsch
Owner

Hmm, github can't seem to reopen issues atm, so I can't reopen #86, so your issue will serve as a handy placeholder for the v1.25 milestone :)

Stephan Michels

This issue isn't fixed in 1.25, correct? As well as #86 ?

Jonathan 'Wolf' Rentzsch
Owner

It's fixed, but I want to make it smarter.

Jacob Gorban

@rentzsch, I am still hit by the missing space on transformable attributes in 1.25.
At least with --template-var arc=true set.

Jonathan 'Wolf' Rentzsch
Owner

Are you sure you're using the latest templates? Please check against https://github.com/rentzsch/mogenerator/tree/master/templates

Apparently if you upgraded via homebrew you don't get upgraded templates by default.

Jacob Gorban

No, Wolf, I just downloaded the 1.25 from here and installed it.
From what I see, the template in master (the machine.h) doesn't have the extra space for transformables.

For now, I fixed my template manually, following changes in Daniel's following commit: danielctull/mogenerator@c51c744

In fact, this very issue has 2 commits from Daniel to address this issue but looks like you didn't merge his proposed changes.

Jonathan 'Wolf' Rentzsch
Owner

Ah, I misunderstood the extent of the problem. Somehow I missed the broken codegen in test mule's ParentMO.myTransformableSansClassName. I thought this issue was more of a SHOULD, but now I understand it's a high-priority MUST.

Jonathan 'Wolf' Rentzsch
Owner

Fixed in 1.26.

Jonathan 'Wolf' Rentzsch rentzsch closed this April 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.