Aligning all pointer stars #103

Merged
merged 2 commits into from May 10, 2012

Conversation

Projects
None yet
2 participants
@tonyarnold
Contributor

tonyarnold commented Apr 16, 2012

The pointer stars were aligned inconsistently throughout the default templates. They have been aligned hard against the variable name or closing bracket, with a preceding space.

Happy to change this to whatever style you prefer @rentzsch, but my OCD side won't let this slide in templates I use everywhere.

Aligning all pointer stars
The pointer stars were aligned inconsistently throughout the default
templates. They have been aligned hard against the variable name or
closing bracket, with a preceding space.
@rentzsch

This comment has been minimized.

Show comment Hide comment
@rentzsch

This comment has been minimized.

Show comment Hide comment
@rentzsch

rentzsch Apr 16, 2012

Owner

Yes, consistency is currently a mess, especially with generated @property vs method return types. I like my asterisks next to the (i)var name, unless it's standalone (like in return types or inside method param parens). This example may help: https://github.com/rentzsch/JRTruthTable/blob/master/JRTruthTable.h

Owner

rentzsch commented Apr 16, 2012

Yes, consistency is currently a mess, especially with generated @property vs method return types. I like my asterisks next to the (i)var name, unless it's standalone (like in return types or inside method param parens). This example may help: https://github.com/rentzsch/JRTruthTable/blob/master/JRTruthTable.h

@tonyarnold

This comment has been minimized.

Show comment Hide comment
@tonyarnold

tonyarnold Apr 16, 2012

Contributor

Thanks, @rentzsch, I'll take those comments and roll them in to this pull request later today.

Contributor

tonyarnold commented Apr 16, 2012

Thanks, @rentzsch, I'll take those comments and roll them in to this pull request later today.

rentzsch added a commit that referenced this pull request May 10, 2012

Merge pull request #103 from tonyarnold/mogenerator
---

The pointer stars were aligned inconsistently throughout the default templates. They have been aligned hard against the variable name or closing bracket, with a preceding space.

Happy to change this to whatever style you prefer @rentzsch, but my OCD side wont let this slide in templates I use everywhere.

@rentzsch rentzsch merged commit 8d4c609 into rentzsch:master May 10, 2012

@rentzsch

This comment has been minimized.

Show comment Hide comment
@rentzsch

rentzsch May 10, 2012

Owner

Pulled, thanks!

Owner

rentzsch commented May 10, 2012

Pulled, thanks!

ddrccw pushed a commit to ddrccw/mogenerator that referenced this pull request Jan 20, 2014

Merge pull request #103 from tonyarnold/mogenerator
---

The pointer stars were aligned inconsistently throughout the default templates. They have been aligned hard against the variable name or closing bracket, with a preceding space.

Happy to change this to whatever style you prefer @rentzsch, but my OCD side wont let this slide in templates I use everywhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment