Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for nullable collection properties #338

Merged
merged 1 commit into from
May 31, 2016
Merged

Allow for nullable collection properties #338

merged 1 commit into from
May 31, 2016

Conversation

ibsh
Copy link

@ibsh ibsh commented May 31, 2016

Summary of Changes

If a to-many relationship property is nullable, the current CoreDataGeneratedAccessors template generates multiple nullability build errors when using -Wnullable-to-nonnull-conversion. This change is a naive fix for those errors but may be appropriate unless more detailed consideration of nullable properties is warranted.

Addresses

Partially addresses #336

If, during CoreDataGeneratedAccessors, a relationship property is null,
fall back to a newly instantiated NSOrderedSet.

If, during CoreDataGeneratedAccessors, a relationship property is null,
fall back to a newly instantiated NSOrderedSet.
@rentzsch rentzsch merged commit 5fb4229 into rentzsch:master May 31, 2016
@sixten
Copy link
Contributor

sixten commented Jul 21, 2016

There appears to be a syntax error in the updated templates: each of the edited lines is missing a closing square bracket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants